Skip to content

gh-134632: Add iOS/Android test skip for C API check for headers.#135656

Merged
freakboy3742 merged 1 commit intopython:mainfrom
freakboy3742:build-details-skip
Jun 18, 2025
Merged

gh-134632: Add iOS/Android test skip for C API check for headers.#135656
freakboy3742 merged 1 commit intopython:mainfrom
freakboy3742:build-details-skip

Conversation

@freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Jun 18, 2025 •
edited by bedevere-app bot
Loading

iOS and Android tests run in an environment where the build headers aren't visible, so testing for their existence won't work.

@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jun 18, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 18, 2025
Closed
@freakboy3742
Copy link
Contributor Author

freakboy3742 commented Jun 18, 2025

!buildbot iOS|android

@bedevere-bot
Copy link

bedevere-bot commented Jun 18, 2025

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 1998591 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135656%2Fmerge

The command will test the builders whose names match following regular expression: iOS|android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR
  • iOS ARM64 Simulator PR

mgorny
mgorny approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Long term, we probably need to think if we don't need to support environments without development files (including without build-details.json) in general, but testing buildbots first is important.

@freakboy3742
Copy link
Contributor Author

freakboy3742 commented Jun 18, 2025

Agreed there's some discussion needed about how iOS/Android should be treated in this case.

The contents of build-details.json file could be useful - especially if it's referencing relative file paths - because for cross-builds, we do have headers, and we need to know how to find them. There will be a big difference between the runtime paths and the cross-build build-time paths - but there's no real meaning for headers etc at runtime, so... maybe there isn't a conflict, and build-details.json just needs to reflect the environment where they've being used in a cross-build.

@freakboy3742 freakboy3742 merged commit 1c7efaf into python:main Jun 18, 2025
49 checks passed
@freakboy3742 freakboy3742 deleted the build-details-skip branch June 18, 2025 06:21
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 18, 2025

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
@freakboy3742 @miss-islington
pythongh-134632: Add iOS/Android test skip for C API check for header…
1051147 
…s. (pythonGH-135656)

iOS and Android don't ship headers in the testbed, so we can't test for their existence.
(cherry picked from commit 1c7efaf)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2025

GH-135657 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
freakboy3742 added a commit that referenced this pull request Jun 18, 2025
@miss-islington @freakboy3742
[3.14] gh-134632: Add iOS/Android test skip for C API check for heade…
562f6d1 
…rs. (GH-135656) (#135657)

iOS and Android don't ship headers in the testbed, so we can't test for their existence.
(cherry picked from commit 1c7efaf)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@freakboy3742 @lkollar
pythongh-134632: Add iOS/Android test skip for C API check for header…
a1826eb 
…s. (python#135656)

iOS and Android don't ship headers in the testbed, so we can't test for their existence.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@freakboy3742 @Pranjal095
pythongh-134632: Add iOS/Android test skip for C API check for header…
9631eac 
…s. (python#135656)

iOS and Android don't ship headers in the testbed, so we can't test for their existence.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@freakboy3742 @taegyunkim
pythongh-134632: Add iOS/Android test skip for C API check for header…
f53aa0f 
…s. (python#135656)

iOS and Android don't ship headers in the testbed, so we can't test for their existence.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@freakboy3742 @Agent-Hellboy
pythongh-134632: Add iOS/Android test skip for C API check for header…
b4d8f29 
…s. (python#135656)

iOS and Android don't ship headers in the testbed, so we can't test for their existence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaro itamaro itamaro approved these changes

+1 more reviewer

@mgorny mgorny mgorny approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@freakboy3742 @bedevere-bot @mgorny @itamaro