Skip to content

gh-81520: Add documentatoion about unexpected os.path.ismount() behaviour#136058

Merged
ZeroIntensity merged 1 commit intopython:mainfrom
bionade24:main
Jul 9, 2025
Merged

gh-81520: Add documentatoion about unexpected os.path.ismount() behaviour#136058
ZeroIntensity merged 1 commit intopython:mainfrom
bionade24:main

Conversation

@bionade24
Copy link
Contributor

@bionade24 bionade24 commented Jun 28, 2025 •
edited by ZeroIntensity
Loading

2 PRs, one adds documentation about the false positives with btrfs subvolumes & the 2nd about adding the unexpected behaviour to the docstring, so that it also shows up in pydoc

📚 Documentation preview 📚: https://cpython-previews--136058.org.readthedocs.build/en/136058/library/os.path.html#os.path.ismount

@python-cla-bot
Copy link

python-cla-bot bot commented Jun 28, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 28, 2025

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jun 28, 2025
Closed
@Zheaoli
Copy link
Contributor

Zheaoli commented Jul 4, 2025

To be honest, I'm not sure we need to clarify this for other similar fs like zfs.

@bionade24 bionade24 marked this pull request as ready for review July 8, 2025 05:09
@bionade24
Copy link
Contributor Author

bionade24 commented Jul 8, 2025

To be honest, I'm not sure we need to clarify this for other similar fs like zfs.

What do you want to tell? This PR has nothing to do with ZFS and I don't know how os.path.ismount() behaves on it.

@bionade24
Copy link
Contributor Author

bionade24 commented Jul 8, 2025

Rebased it on main. Anything else that I need to do?

@ZeroIntensity ZeroIntensity added the docs Documentation in the Doc dir label Jul 9, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jul 9, 2025
@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 9, 2025
ZeroIntensity
ZeroIntensity reviewed Jul 9, 2025
View reviewed changes
@bionade24 bionade24 requested a review from ZeroIntensity July 9, 2025 08:51
ZeroIntensity
ZeroIntensity reviewed Jul 9, 2025
View reviewed changes
@bionade24 bionade24 requested a review from ZeroIntensity July 9, 2025 14:36
ZeroIntensity
ZeroIntensity reviewed Jul 9, 2025
View reviewed changes
@bionade24 bionade24 requested a review from ZeroIntensity July 9, 2025 15:47
@ZeroIntensity
Copy link
Member

ZeroIntensity commented Jul 9, 2025

FWIW, you don't need to force-push. We squash at the end anyway, and it just makes reviewing a little more difficult.

ZeroIntensity
ZeroIntensity approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ZeroIntensity ZeroIntensity merged commit 591abcc into python:main Jul 9, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 9, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Jul 9, 2025

Thanks @bionade24 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@bionade24 @miss-islington
pythongh-81520: Document unexpected os.path.ismount behaviour with …
fb086fe 
…btrfs subvolumes (pythonGH-136058)

(cherry picked from commit 591abcc)

Co-authored-by: Oskar Roesler <o.roesler@oscloud.info>
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136471 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 9, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 9, 2025
@bionade24 @miss-islington
pythongh-81520: Document unexpected os.path.ismount behaviour with …
8f473f8 
…btrfs subvolumes (pythonGH-136058)

(cherry picked from commit 591abcc)

Co-authored-by: Oskar Roesler <o.roesler@oscloud.info>
@bedevere-app
Copy link

bedevere-app bot commented Jul 9, 2025

GH-136473 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 9, 2025
@ZeroIntensity
Copy link
Member

ZeroIntensity commented Jul 9, 2025

Congrats on your first contribution :)

ZeroIntensity pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @bionade24
[3.14] gh-81520: Document unexpected os.path.ismount behaviour with…
7835940 
… btrfs subvolumes (GH-136058) (GH-136471)

gh-81520: Document unexpected `os.path.ismount` behaviour with btrfs subvolumes (GH-136058)
(cherry picked from commit 591abcc)

Co-authored-by: Oskar Roesler <o.roesler@oscloud.info>
ZeroIntensity pushed a commit that referenced this pull request Jul 9, 2025
@miss-islington @bionade24
[3.13] gh-81520: Document unexpected os.path.ismount behaviour with…
6c81051 
… btrfs subvolumes (GH-136058) (GH-136473)

gh-81520: Document unexpected `os.path.ismount` behaviour with btrfs subvolumes (GH-136058)
(cherry picked from commit 591abcc)

Co-authored-by: Oskar Roesler <o.roesler@oscloud.info>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@bionade24 @AndPuQing
pythongh-81520: Document unexpected os.path.ismount behaviour with …
6be101d 
…btrfs subvolumes (pythonGH-136058)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@bionade24 @Pranjal095
pythongh-81520: Document unexpected os.path.ismount behaviour with …
2ce3a79 
…btrfs subvolumes (pythonGH-136058)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@bionade24 @picnixz
pythongh-81520: Document unexpected os.path.ismount behaviour with …
088e22d 
…btrfs subvolumes (pythonGH-136058)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@bionade24 @taegyunkim
pythongh-81520: Document unexpected os.path.ismount behaviour with …
13cf0fd 
…btrfs subvolumes (pythonGH-136058)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@bionade24 @Agent-Hellboy
pythongh-81520: Document unexpected os.path.ismount behaviour with …
fdbe81d 
…btrfs subvolumes (pythonGH-136058)
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @bionade24 @kumaraditya303
[3.14] pythongh-81520: Document unexpected os.path.ismount behaviou…
3faa03d 
…r with btrfs subvolumes (pythonGH-136058) (pythonGH-136471)

pythongh-81520: Document unexpected `os.path.ismount` behaviour with btrfs subvolumes (pythonGH-136058)
(cherry picked from commit 591abcc)

Co-authored-by: Oskar Roesler <o.roesler@oscloud.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bionade24 @Zheaoli @ZeroIntensity @brianschubert