Skip to content

GH-136410: Faster side exits #136411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 15 commits into from
Aug 1, 2025
Merged

GH-136410: Faster side exits #136411

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
a281775
Faster side exits.
markshannon Jul 7, 2025
ec7f0e2
Fix copy-and-paste error
markshannon Jul 7, 2025
911520a
Check validity at start of trace
markshannon Jul 7, 2025
73832b2
Tidy up
markshannon Jul 8, 2025
a9297a0
Null test before use
markshannon Jul 8, 2025
47b53d1
Update asserts
markshannon Jul 8, 2025
2564d41
Properly fix assert
markshannon Jul 8, 2025
779bd7d
Don't make object immortal until it is fully initialized
markshannon Jul 8, 2025
db336ce
Merge branch 'main' into fast-side-exits
markshannon Jul 21, 2025
0b05acf
Free cold executor when closing of interpreter
markshannon Jul 21, 2025
142bab6
Add NULL check
markshannon Jul 21, 2025
af696ea
Free cold executor after final GC
markshannon Jul 22, 2025
264559a
Add empty _PyExecutor_Free for non-jit builds
markshannon Jul 22, 2025
989a882
Clear exit if START_EXECUTOR detects that the executor is invalid
markshannon Jul 30, 2025
656ada0
Add some asserts
markshannon Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tidy up
  • Loading branch information
@markshannon
markshannon committed Jul 8, 2025
commit 73832b244e3f634a4a2589908d53d50305fcb1fc
6 changes: 3 additions & 3 deletions Python/bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2964,7 +2964,7 @@ dummy_func(
else {
this_instr[1].counter = initial_jump_backoff_counter();
assert(tstate->current_executor == NULL);
tstate->jit_exit = NULL;
assert(executor != tstate->interp->cold_executor);
GOTO_TIER_TWO(executor);
}
}
Expand Down Expand Up @@ -3029,7 +3029,7 @@ dummy_func(
}
DISPATCH_GOTO();
}
tstate->jit_exit = NULL;
assert(executor != tstate->interp->cold_executor);
GOTO_TIER_TWO(executor);
#else
Py_FatalError("ENTER_EXECUTOR is not supported in this build");
Expand Down Expand Up @@ -5238,7 +5238,7 @@ dummy_func(
#endif
}

tier2 op(_EXIT_TRACE, (exit_p/4 -- )) {
tier2 op(_EXIT_TRACE, (exit_p/4 --)) {
_PyExitData *exit = (_PyExitData *)exit_p;
#if defined(Py_DEBUG) && !defined(_Py_JIT)
_Py_CODEUNIT *target = _PyFrame_GetBytecode(frame) + exit->target;
Expand Down
4 changes: 2 additions & 2 deletions Python/generated_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,7 @@ dummy_func(void) {
ctx->done = true;
}

op(_EXIT_TRACE, (exit_p/4 -- )) {
op(_EXIT_TRACE, (exit_p/4 --)) {
(void)exit_p;
ctx->done = true;
}
Expand Down
Loading