Skip to content

gh-138568: make it the same behavior in repl help mode #138569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yihong0618 wants to merge 12 commits into from
Closed

gh-138568: make it the same behavior in repl help mode #138569

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f1eba0c
fix: make it the same behavior in repl help mode
yihong0618 Sep 6, 2025
9e16e68
fix: address commnets add tests and better news
yihong0618 Sep 6, 2025
b50ffbb
更新 2025-09-06-08-29-08.gh-issue-138568.iZlalC.rst
yihong0618 Sep 6, 2025
575462a
fix: lint and words
yihong0618 Sep 6, 2025
4201a09
Update Misc/NEWS.d/next/Library/2025-09-06-08-29-08.gh-issue-138568.i…
yihong0618 Sep 6, 2025
7462dbb
fix: address comments
yihong0618 Sep 7, 2025
6fa1136
Update Lib/pydoc.py
yihong0618 Sep 7, 2025
3b4915a
fix: move the news to core and buildins dir
yihong0618 Sep 10, 2025
2babb7d
fix: apply suggestions from code review
yihong0618 Sep 10, 2025
4cae1c2
fix: the tests
yihong0618 Sep 10, 2025
2c4944c
fix: test wrong on windows
yihong0618 Sep 10, 2025
64d9f36
Apply suggestions from code review
yihong0618 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: adam j hartz <hz@mit.edu>
  • Loading branch information
@yihong0618 @adqm
yihong0618 and adqm authored Sep 10, 2025
commit 64d9f3661153775146671180801d140f6b50f815
6 changes: 3 additions & 3 deletions Lib/test/test_pydoc/test_pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,7 +2180,7 @@ def mock_getline(prompt):
helper.interact()

# handle different line endings across platforms consistently
return output.getvalue().splitlines(keepends=False) + ['']
return output.getvalue().strip().splitlines(keepends=False)

def test_keywords(self):
self.assertEqual(sorted(pydoc.Helper.keywords),
Expand All @@ -2190,7 +2190,7 @@ def test_interact_empty_line_continues(self):
# gh-138568: test pressing Enter without input should continue in help session
self.assertEqual(
self.mock_interactive_session(["", " ", "quit"]),
["", "help> ", "help> ", "help> quit", ""],
["help> ", "help> ", "help> quit"],
)

def test_interact_quit_commands_exit(self):
Expand All @@ -2199,7 +2199,7 @@ def test_interact_quit_commands_exit(self):
with self.subTest(quit_command=quit_cmd):
self.assertEqual(
self.mock_interactive_session([quit_cmd]),
["", f"help> {quit_cmd}", ""],
[f"help> {quit_cmd}"],
)


Expand Down
Loading