Skip to content

gh-71810: fix corner case (length==0) for int.to_bytes() #138739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 6 commits into from
Sep 11, 2025
Merged

gh-71810: fix corner case (length==0) for int.to_bytes() #138739

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
33f60b9
gh-71810: fix corner case (length==0) for int.to_bytes()
skirpichev Sep 10, 2025
ea3d52f
add news
skirpichev Sep 10, 2025
f0090e7
address review: test for 128/-129
skirpichev Sep 10, 2025
db7182a
+1
skirpichev Sep 11, 2025
aff76b8
Apply suggestions from code review
skirpichev Sep 11, 2025
60732b7
+ fix typo
skirpichev Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
  • Loading branch information
@skirpichev @serhiy-storchaka
skirpichev and serhiy-storchaka authored Sep 11, 2025
commit aff76b84ea435efd917f6ac2640e9a5cef927143
3 changes: 1 addition & 2 deletions Lib/test/test_long.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1374,16 +1374,15 @@ def equivalent_python(n, length, byteorder, signed=False):
check(tests4, 'little', signed=False)

self.assertRaises(OverflowError, (256).to_bytes, 1, 'big', signed=False)
self.assertRaises(OverflowError, (256).to_bytes, 1, 'big', signed=True)
self.assertRaises(OverflowError, (256).to_bytes, 1, 'little', signed=False)
self.assertRaises(OverflowError, (256).to_bytes, 1, 'little', signed=True)
self.assertRaises(OverflowError, (128).to_bytes, 1, 'big', signed=True)
self.assertRaises(OverflowError, (128).to_bytes, 1, 'little', signed=True)
self.assertRaises(OverflowError, (-129).to_bytes, 1, 'big', signed=True)
self.assertRaises(OverflowError, (-129).to_bytes, 1, 'little', signed=True)
self.assertRaises(OverflowError, (-1).to_bytes, 2, 'big', signed=False)
self.assertRaises(OverflowError, (-1).to_bytes, 2, 'little', signed=False)
self.assertEqual((0).to_bytes(0, 'big'), b'')
self.assertEqual((0).to_bytes(0, 'big'), b'', signed=True)
self.assertEqual((1).to_bytes(5, 'big'), b'\x00\x00\x00\x00\x01')
self.assertEqual((0).to_bytes(5, 'big'), b'\x00\x00\x00\x00\x00')
self.assertEqual((-1).to_bytes(5, 'big', signed=True),
Expand Down
Loading