Skip to content

gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()#139396

Merged
vstinner merged 10 commits intopython:mainfrom
Wulian233:doc
Mar 20, 2026
Merged

gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr()#139396
vstinner merged 10 commits intopython:mainfrom
Wulian233:doc

Conversation

@Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Sep 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 28, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Sep 28, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 28, 2025
Closed
AA-Turner

This comment was marked as outdated.

Sign in to view

@bedevere-app

This comment was marked as outdated.

Sign in to view
@Wulian233

This comment was marked as outdated.

Sign in to view
@AA-Turner
Copy link
Member

AA-Turner commented Oct 3, 2025

Ok, I'm proposing to remove that note from the 'A new type of interpreter' section, and I've also made the envvar change in the 'New & improved modules' PR. Could you retarget this PR to just make the zipfile.rst change?

A

@Wulian233 Wulian233 changed the title gh-123299: Copyedit What's New in 3.14 gh-123299: Copyedit What's New in zipfile.rst Oct 3, 2025
@AA-Turner AA-Turner changed the title gh-123299: Copyedit What's New in zipfile.rst gh-123299: Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Oct 3, 2025
@Wulian233
Copy link
Contributor Author

Wulian233 commented Oct 3, 2025

Could you retarget this PR to just make the zipfile.rst change?

Finished, thank you!

AA-Turner
AA-Turner previously requested changes Oct 4, 2025
View reviewed changes
@AA-Turner AA-Turner changed the title gh-123299: Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Oct 4, 2025
@Wulian233 Wulian233 requested a review from AA-Turner October 11, 2025 12:07
@vstinner vstinner changed the title Note SOURCE_DATE_EPOCH support in ZipFile.writestr() gh-91279: Note SOURCE_DATE_EPOCH support in ZipFile.writestr() Nov 4, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 4, 2025
Closed
vstinner
vstinner reviewed Nov 4, 2025
View reviewed changes
@Wulian233 @vstinner
Update Doc/library/zipfile.rst
217b831 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but English is not my first language, so I'm not sure about the sentence :-)

@Wulian233
Copy link
Contributor Author

Wulian233 commented Mar 20, 2026

ping @vstinner @AA-Turner

@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Mar 20, 2026
vstinner
vstinner reviewed Mar 20, 2026
View reviewed changes
@vstinner vstinner dismissed AA-Turner’s stale review March 20, 2026 12:09

I think the text can be improved here. The sentence lacks an object, but more importantly we don't say what has actually changed in the method's behaviour if SDE is set.

The sentence was completed.

@vstinner vstinner enabled auto-merge (squash) March 20, 2026 12:09
@Wulian233
Copy link
Contributor Author

Wulian233 commented Mar 20, 2026

thanks!

@vstinner
Copy link
Member

vstinner commented Mar 20, 2026

"All required checks pass" CI failed with a cryptic error message:

Error: The template is not valid. .github/workflows/build.yml (Line: 671, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.

So I updated the branch to attempt to fix the CI issue.

@vstinner vstinner merged commit 5ad738f into python:main Mar 20, 2026
28 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 20, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 20, 2026

Thanks @Wulian233 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 20, 2026
@Wulian233 @vstinner @miss-islington
pythongh-91279: Note SOURCE_DATE_EPOCH support in `ZipFile.writestr…
9cec510 
…()` doc (pythonGH-139396)

(cherry picked from commit 5ad738f8fb214e9852dc527e6754cbfb7abf6cc8)

Co-authored-by: Wulian233 <1055917385@qq.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Mar 20, 2026

GH-146222 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 20, 2026
@vstinner
Copy link
Member

vstinner commented Mar 20, 2026

Merged, thanks for fixing the doc.

vstinner added a commit that referenced this pull request Mar 20, 2026
@miss-islington @Wulian233 @vstinner
[3.14] gh-91279: Note SOURCE_DATE_EPOCH support in `ZipFile.writest…
8b447fb 
…r()` doc (GH-139396) (#146222)

gh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (GH-139396)
(cherry picked from commit 5ad738f)

Co-authored-by: Wulian233 <1055917385@qq.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wulian233 @AA-Turner @vstinner @nazeerali4325-commits