Skip to content

gh-140633: AppleFrameworkLoader: Ignore AttributeError when setting __file__#140635

Merged
encukou merged 1 commit intopython:mainfrom
encukou:appleframeworkloader-attributeerror
Oct 27, 2025
Merged

gh-140633: AppleFrameworkLoader: Ignore AttributeError when setting __file__#140635
encukou merged 1 commit intopython:mainfrom
encukou:appleframeworkloader-attributeerror

Conversation

@encukou
Copy link
Member

@encukou encukou commented Oct 26, 2025 •
edited by bedevere-app bot
Loading

@encukou encukou requested a review from freakboy3742 October 26, 2025 15:28
@bedevere-app bedevere-app bot mentioned this pull request Oct 26, 2025
Closed
@freakboy3742
Copy link
Contributor

freakboy3742 commented Oct 27, 2025

!buildbot iOS

@bedevere-bot
Copy link

bedevere-bot commented Oct 27, 2025

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 727bfa1 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140635%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

freakboy3742
freakboy3742 approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I fully follow the scenario where this would happen in practice (i.e., under what practical circumstances would Py_mod_create return an immutable non-module object?) - but if the object doesn't have a __file__, this seems like a reasonable (and consistent) response. __file__ isn't needed at runtime for the Apple Framework loader to operate; and it's passing CI with this change - so I guess it's OK to merge.

@freakboy3742
Copy link
Contributor

freakboy3742 commented Oct 27, 2025

@encukou One additional thought - Is this behavior a new feature of 3.15, or does this require back porting to 3.14/13?

@encukou
Copy link
Member Author

encukou commented Oct 27, 2025

I agree it's not immediately practical.

(What is sometimes practical is non-module objects in general. While implementing PEP 793 and testing the edge cases, I used a string to keep the test simple. Guess strings are too simple!)

The behaviour is not new. I don't think it requires backporting, but it's probably better to file off an obscure sharp edge.

@encukou encukou merged commit 3416e7c into python:main Oct 27, 2025
52 checks passed
@encukou encukou deleted the appleframeworkloader-attributeerror branch October 27, 2025 09:22
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 27, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 27, 2025

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 27, 2025

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2025
@encukou @miss-islington
pythongh-140633: AppleFrameworkLoader: Ignore AttributeError when set…
16a2758 
…ting __file__ (pythonGH-140635)

(cherry picked from commit 3416e7c)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 27, 2025
@encukou @miss-islington
pythongh-140633: AppleFrameworkLoader: Ignore AttributeError when set…
8726089 
…ting __file__ (pythonGH-140635)

(cherry picked from commit 3416e7c)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 27, 2025

GH-140659 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 27, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 27, 2025

GH-140660 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 27, 2025
encukou added a commit that referenced this pull request Oct 27, 2025
@miss-islington @encukou
[3.14] gh-140633: AppleFrameworkLoader: Ignore AttributeError when se…
87afee2 
…tting __file__ (GH-140635) (GH-140660)

(cherry picked from commit 3416e7c)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request Oct 27, 2025
@miss-islington @encukou
[3.13] gh-140633: AppleFrameworkLoader: Ignore AttributeError when se…
0e3b47b 
…tting __file__ (GH-140635) (GH-140659)

(cherry picked from commit 3416e7c)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@encukou @StanFromIreland
pythongh-140633: AppleFrameworkLoader: Ignore AttributeError when set…
3dff211 
…ting __file__ (pythonGH-140635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou @freakboy3742 @bedevere-bot