Skip to content

gh-140870: PyREPL auto-complete module attributes in import statements #140871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loic-simon wants to merge 17 commits into
base: main
Choose a base branch
from
Open

gh-140870: PyREPL auto-complete module attributes in import statements #140871

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1bbfb9b
gh-140870 PyREPL: add import completion for attributes
loic-simon Nov 1, 2025
699848b
Full coverage for _pyrepl._module_completer
loic-simon Nov 1, 2025
c0cb4aa
Improve behavior when both submodules + prompt
loic-simon Nov 4, 2025
8fd78ca
Merge branch 'main' into pyrepl-import-completion-for-attributes
loic-simon Dec 28, 2025
58e0e3d
Auto-import stdlib modules
loic-simon Jan 1, 2026
6a5877f
Blacklist some stdlib modules from auto-import
loic-simon Jan 2, 2026
ec8b314
Merge branch 'main' into pyrepl-import-completion-for-attributes
loic-simon Jan 5, 2026
134fd78
Fix tests post rebase
loic-simon Jan 5, 2026
a403b1c
Improve & test auto-import blacklist
loic-simon Jan 10, 2026
58f4da0
Add _ios_support to auto import blacklist
loic-simon Jan 10, 2026
3eec508
Fix tests requiring tkinter
loic-simon Jan 10, 2026
9c80367
Avoid charged terminology
loic-simon Jan 11, 2026
935e3fd
Use always available modules in tests + invalidate caches
loic-simon Jan 11, 2026
da6cf7f
Don't test with html module either
loic-simon Jan 11, 2026
e34a434
Fix refleaks in test_pyrepl.py
loic-simon Jan 24, 2026
0106165
Merge branch 'main' into pyrepl-import-completion-for-attributes
loic-simon Jan 24, 2026
0235896
Merge branch 'python:main' into pyrepl-import-completion-for-attributes
loic-simon Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests post rebase
  • Loading branch information
@loic-simon
loic-simon committed Jan 5, 2026
commit 134fd78a934838ad1950bae20d930f5b85d535a7
26 changes: 13 additions & 13 deletions Lib/test/test_pyrepl/test_pyrepl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,7 +1009,6 @@ def test_private_completions(self):
ModuleInfo(None, "_private", True),
],
)
@patch.dict(sys.modules, {"foo": object()}) # don't propose to import it
def test_sub_module_private_completions(self):
cases = (
# Return public methods by default
Expand Down Expand Up @@ -1288,19 +1287,20 @@ def test_attribute_completion_error_on_import(self):
self.assertEqual(output, expected)
self.assertNotIn("boom", sys.modules)

@patch.dict(sys.modules)
def test_attribute_completion_error_on_attributes_access(self):
class BrokenModule:
def __dir__(self):
raise ValueError("boom")

with (patch.dict(sys.modules, {"boom": BrokenModule()}),
patch("_pyrepl._module_completer.ModuleCompleter.iter_submodules",
lambda *_: [ModuleInfo(None, "submodule", False)])):
events = code_to_events("from boom import \t\n")
reader = self.prepare_reader(events, namespace={})
output = reader.readline()
# ignore attributes, just propose submodule
self.assertEqual(output, "from boom import submodule")
with tempfile.TemporaryDirectory() as _dir:
dir = pathlib.Path(_dir)
(dir / "boom").mkdir()
(dir / "boom"/"__init__.py").write_text("def __dir__(): raise ValueError()")
(dir / "boom"/"submodule.py").touch()
with patch.object(sys, "path", [_dir, *sys.path]):
events = code_to_events("from boom import \t\t\n") # trigger import
reader = self.prepare_reader(events, namespace={})
output = reader.readline()
self.assertIn("boom", sys.modules)
# ignore attributes, just propose submodule
self.assertEqual(output, "from boom import submodule")

@patch.dict(sys.modules)
def test_attribute_completion_private_and_invalid_names(self):
Expand Down
Loading