Skip to content

gh-140260: Fix data race in _struct module initialization with subinterpreters #140909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 20 commits into from
Nov 13, 2025
Merged

gh-140260: Fix data race in _struct module initialization with subinterpreters #140909

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
243b5f0
Fix data race in _struct module endian table initialization
ashm-dev Nov 2, 2025
4c9892e
fix doc
ashm-dev Nov 2, 2025
95958e8
refactor(c-analyzer): add endian_tables_init_once to globals-to-fix list
ashm-dev Nov 2, 2025
3130512
Use Py_UNUSED for unused arg in init_endian_tables
ashm-dev Nov 2, 2025
d33514b
fix: remove duplicate include of pycore_lock.h in _struct.c
ashm-dev Nov 2, 2025
c4f577f
add test
ashm-dev Nov 3, 2025
238c40e
Remove return check for endian table init
ashm-dev Nov 3, 2025
f4d24ff
Use InterpreterPoolExecutor in struct tests
ashm-dev Nov 3, 2025
2977abf
Ignore return value of _PyOnceFlag_CallOnce
ashm-dev Nov 3, 2025
5e6b45b
Move endian_tables_init_once to ignored.tsv
ashm-dev Nov 3, 2025
4492520
Import InterpreterPoolExecutor locally in test
ashm-dev Nov 3, 2025
a1caec9
Skip subinterpreter init test unless GIL disabled
ashm-dev Nov 3, 2025
f1cf169
Inline exec and wrap skipUnless args
ashm-dev Nov 5, 2025
1408896
Skip test when InterpreterPoolExecutor missing
ashm-dev Nov 5, 2025
359ae9a
Fix executor.map usage in test_struct
ashm-dev Nov 5, 2025
47494a4
Pass exec to executor.map
ashm-dev Nov 5, 2025
93830ea
Merge branch 'main' into tsan
ZeroIntensity Nov 5, 2025
434dbab
Merge branch 'main' into tsan
kumaraditya303 Nov 6, 2025
3844826
fix: tests
ashm-dev Nov 13, 2025
b825107
Merge branch 'main' into tsan
kumaraditya303 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: tests
  • Loading branch information
@ashm-dev
ashm-dev committed Nov 13, 2025
commit 3844826a0452baf50a00077920151ee3ea0f5f54
4 changes: 4 additions & 0 deletions Lib/test/test_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,6 +800,10 @@ def test_c_complex_round_trip(self):
round_trip = struct.unpack(f, struct.pack(f, z))[0]
self.assertComplexesAreIdentical(z, round_trip)

@unittest.skipIf(
support.is_android or support.is_apple_mobile,
"Subinterpreters are not supported on Android and iOS"
)
def test_endian_table_init_subinterpreters(self):
# Verify that the _struct extension module can be initialized
# concurrently in subinterpreters (gh-140260).
Expand Down
Loading