Skip to content

gh-139871: Optimize bytearray unique bytes iconcat #141862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmaloney wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-139871: Optimize bytearray unique bytes iconcat #141862

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db4c09a
gh-139871: Optimize bytearray unique bytes iconcat
cmaloney Nov 18, 2025
08364c1
Apply suggestions from code review
cmaloney Nov 24, 2025
70c15bf
Switch from comment to assertion
cmaloney Nov 24, 2025
614e743
Call take_bytes directly
cmaloney Dec 3, 2025
c5e9da6
Update Objects/bytearrayobject.c
cmaloney Dec 3, 2025
e6fd741
Borrow -> Borrowed
cmaloney Dec 3, 2025
fe114fb
Merge branch 'main' into ba_tb_concat
cmaloney Dec 15, 2025
c689a0a
Use PyUnstable_Object_IsUniqueReferencedTemporary
cmaloney Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Objects/bytearrayobject.c 
Co-authored-by: Victor Stinner <vstinner@python.org>
  • Loading branch information
@cmaloney @vstinner
cmaloney and vstinner authored Dec 3, 2025
commit c5e9da6ae9c8ad04cb32fa0c64949c26354dedbb
2 changes: 1 addition & 1 deletion Objects/bytearrayobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ bytearray_iconcat_lock_held(PyObject *op, PyObject *other)

// optimization: Avoid copying the bytes coming in when possible.
if (self->ob_alloc == 0 && _PyObject_IsUniquelyReferenced(other)) {
assert(_Py_IsImmortal(self->ob_bytes_object));
assert(self->ob_bytes_object == Py_GetConstantBorrow(Py_CONSTANT_EMPTY_BYTES));
if (!_canresize(self)) {
return NULL;
}
Expand Down
Loading