Skip to content

gh-142737: Handle lost io.open in _Py_FindSourceFile #142747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZeroIntensity merged 19 commits into from
Dec 15, 2025
Merged

gh-142737: Handle lost io.open in _Py_FindSourceFile #142747

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
cf8b9c3
Check `callable` isn't `NULL` in `_PyObject_CallMethodFormat`
johnslavik Dec 15, 2025
1cb2a7e
Add initial test idea
johnslavik Dec 15, 2025
e5c77a0
Give test cases meaningful names
johnslavik Dec 15, 2025
173fd5c
Skip tests that require lines to be captured
johnslavik Dec 15, 2025
6b81561
Add news entry
johnslavik Dec 15, 2025
323385d
Goto `error` immediately if we can't get handle to `io.open`
johnslavik Dec 15, 2025
092356b
Clarify skip reason
johnslavik Dec 15, 2025
1a971f4
Add some docs & comments to tests
johnslavik Dec 15, 2025
206633c
Elaborate in the news entry
johnslavik Dec 15, 2025
d95a3d4
Use a subprocess-based test
johnslavik Dec 15, 2025
36a91ad
Examine `rc` to make sure it's not a crash
johnslavik Dec 15, 2025
b3d1296
Simplify minimal reproducer
johnslavik Dec 15, 2025
e0933bb
Fiat lux
johnslavik Dec 15, 2025
6589e9f
Fix formatting
johnslavik Dec 15, 2025
bea29ea
Apply suggestion from @johnslavik
johnslavik Dec 15, 2025
77effbc
Apply suggestion from @johnslavik
johnslavik Dec 15, 2025
45774d2
Add `assert(callable != NULL)` in `_PyObject_CallMethodFormat`
johnslavik Dec 15, 2025
ae292f5
Mark as CPython-only and mention `_Py_FindSourceFile`
johnslavik Dec 15, 2025
f9aae29
Better wording in the comment
johnslavik Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark as CPython-only and mention _Py_FindSourceFile
  • Loading branch information
@johnslavik
johnslavik committed Dec 15, 2025
commit ae292f554c1225353efdb0f52188ab82a18e3b18
2 changes: 2 additions & 0 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,7 @@ def __del__(self):
b'ZeroDivisionError: division by zero']
self.assertEqual(stderr.splitlines(), expected)

@cpython_only
def test_lost_io_open(self):
# GH-142737: Display the traceback even if io.open is lost
crasher = textwrap.dedent("""\
Expand All @@ -535,6 +536,7 @@ def test_lost_io_open(self):
raise RuntimeError("should not crash")
""")

# Create a temporary script to go through _Py_FindSourceFile
with temp_dir() as script_dir:
script = make_script(
script_dir=script_dir,
Expand Down
Loading