Skip to content

gh-143394: On macOS, run main PyREPL tests as "Apple Terminal" as well#143461

Merged
ambv merged 1 commit intopython:mainfrom
ambv:gh-143394-followup
Jan 6, 2026
Merged

gh-143394: On macOS, run main PyREPL tests as "Apple Terminal" as well#143461
ambv merged 1 commit intopython:mainfrom
ambv:gh-143394-followup

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Jan 5, 2026

This would have prevented the issue introduced in gh-138732 by catching the missing safe escape code:

Screenshot 2026-01-05 at 23 23 04

@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jan 5, 2026
@ambv ambv added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 5, 2026
@ambv ambv merged commit 7dae107 into python:main Jan 6, 2026
54 checks passed
@miss-islington-app
Copy link

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2026
…as well (pythonGH-143461)

(cherry picked from commit 7dae107)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2026
…as well (pythonGH-143461)

(cherry picked from commit 7dae107)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2026

GH-143466 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 6, 2026
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2026

GH-143467 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 6, 2026
ambv added a commit that referenced this pull request Jan 6, 2026
… as well (GH-143461) (GH-143466)

(cherry picked from commit 7dae107)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
ambv added a commit that referenced this pull request Jan 6, 2026
… as well (GH-143461) (GH-143467)

(cherry picked from commit 7dae107)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants