Skip to content

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs#146417

Open
hoodmane wants to merge 4 commits intopython:mainfrom
hoodmane:streams
Open

gh-146416: Emscripten: Improve standard stream handling in node_entry.mjs#146417
hoodmane wants to merge 4 commits intopython:mainfrom
hoodmane:streams

Conversation

@hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Mar 25, 2026 •
edited by bedevere-app bot
Loading

@hoodmane hoodmane requested review from freakboy3742 and removed request for AA-Turner, corona10, emmatyping and erlend-aasland March 25, 2026 13:13
@bedevere-app bedevere-app bot mentioned this pull request Mar 25, 2026
Open
@vstinner
Copy link
Member

vstinner commented Mar 25, 2026

The test suite fails on Emscripten with nodeFsync is not defined: https://github.com/python/cpython/actions/runs/23545540285/job/68544804717?pr=146417


0:00:13 load avg: 0.10 [ 78/502] test.test_os.test_os
file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:189
    nodeFsync(this.nodeStream.fd);
    ^

ReferenceError: nodeFsync is not defined
    at NodeWriter.fsync (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:189:5)
    at Object.fsync (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:136:11)
    at Object.close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/streams.mjs:131:23)
    at Object.close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/python.mjs:1:71931)
    at _fd_close (file:///home/runner/work/cpython/cpython/cross-build/wasm32-emscripten/build/python/python.mjs:1:271594)
    at wasm://wasm/02b6ddae:wasm-function[12183]:0x69a8ab
    at wasm://wasm/02b6ddae:wasm-function[8357]:0x498ddf
    at wasm://wasm/02b6ddae:wasm-function[1978]:0x1e167a
    at wasm://wasm/02b6ddae:wasm-function[803]:0x18e943
    at wasm://wasm/02b6ddae:wasm-function[3473]:0x2ad92d

Node.js v24.14.0
Error: Process completed with exit code 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742

Assignees

No one assigned

Labels

awaiting review needs backport to 3.14 bugs and security fixes OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoodmane @vstinner