Skip to content

bpo-40024: Update xxxxmodule to use PyModule_AddType. #19119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 16 commits into from
Mar 24, 2020
Merged

bpo-40024: Update xxxxmodule to use PyModule_AddType. #19119

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
de9587b
bpo-40024: Update blake2module to use PyModule_AddType
corona10 Mar 23, 2020
af8c626
bpo-40024: Update _queuemodule to use PyModule_AddType
corona10 Mar 23, 2020
bc76064
bpo-40024: Update _bz2module to use PyModule_AddType
corona10 Mar 23, 2020
f05f7f2
bpo-40024: Update _operator to use PyModule_AddType.
corona10 Mar 23, 2020
473c693
bpo-40024: Update _csv.c to use PyModule_AddType.
corona10 Mar 23, 2020
08bbe86
bpo-40024: Update _asynciomodule to use PyModule_AddType.
corona10 Mar 23, 2020
31f441a
bpo-40024: Update multibytecodec to use PyModule_AddType.
corona10 Mar 23, 2020
e86a225
bpo-40024: Update _datetimemodule to use PyModule_AddType.
corona10 Mar 23, 2020
2f59468
bpo-40024: Update _pickle.c to use PyModule_AddType.
corona10 Mar 23, 2020
f4bf212
bpo-40024: Update overlapped.c to use PyModule_AddType.
corona10 Mar 23, 2020
2ac5a85
bpo-40024: Update _datetimemoudle for codereview.
corona10 Mar 24, 2020
525ede5
bpo-40024: Update multibytecodec.c
corona10 Mar 24, 2020
ee0343f
bpo-40024: Update _operator.c
corona10 Mar 24, 2020
839e4e9
bpo-40024: Update _asynciomodule
corona10 Mar 24, 2020
95ea687
bpo-40024: Update macro of _iomodule to use PyModule_AddType.
corona10 Mar 24, 2020
ff64806
bpo-40024: Update _cursesmodule to use PyModule_AddType.
corona10 Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-40024: Update _datetimemoudle for codereview.
  • Loading branch information
@corona10
corona10 committed Mar 24, 2020
commit 2ac5a8545b5bdcacded72b9a37a5c1d73925ab6a
39 changes: 12 additions & 27 deletions Modules/_datetimemodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6386,34 +6386,19 @@ PyInit__datetime(void)
if (m == NULL)
return NULL;

if (PyModule_AddType(m, &PyDateTime_DateType) < 0) {
Py_DECREF(m);
return NULL;
}

if (PyModule_AddType(m, &PyDateTime_DateTimeType) < 0) {
Py_DECREF(m);
return NULL;
}

if (PyModule_AddType(m, &PyDateTime_TimeType) < 0) {
Py_DECREF(m);
return NULL;
}

if (PyModule_AddType(m, &PyDateTime_DeltaType) < 0) {
Py_DECREF(m);
return NULL;
}

if (PyModule_AddType(m, &PyDateTime_TZInfoType) < 0) {
Py_DECREF(m);
return NULL;
}
PyTypeObject *types[] = {
&PyDateTime_DateType,
&PyDateTime_DateTimeType,
&PyDateTime_TimeType,
&PyDateTime_DeltaType,
&PyDateTime_TZInfoType,
&PyDateTime_TimeZoneType
};

if (PyModule_AddType(m, &PyDateTime_TimeZoneType) < 0) {
Py_DECREF(m);
return NULL;
for (size_t i = 0; i < Py_ARRAY_LENGTH(types); i++) {
if (PyModule_AddType(m, types[i]) < 0) {
return NULL;
}
}

/* timedelta values */
Expand Down