gh-85046: Adding missing errno system symbols descriptions#20665
gh-85046: Adding missing errno system symbols descriptions#20665YoSTEALTH wants to merge 10 commits intopython:mainfrom
Conversation
|
remilapeyre
left a comment
There was a problem hiding this comment.
Thanks for adding some, the following ones are still missing as far as I can tell:
- EPROCLIM
- WSAENOTEMPTY
- WSAEHOSTDOWN
- WSAEADDRINUSE
- WSAECONNABORTED
- WSABASEERR
- WSAEPFNOSUPPORT
- WSAHOS
- WSAVERNOTSUPPORTED
- WSAECONNREFUSED
- WSAETIMEDOUT
- WSAEADDRNOTAVAIL
- WSAEBADF
- WSAEALREADY
- WSAEISCONN
- WSAEUSERS
- WSANOTINITIALISED
- WSAEREMOTE
- WSAEINTR
- WSAEPROTOTYPE
- EBADARCH
- WSAEPROCLIM
- EPROGUNAVAIL
- WSAENOPROTOOPT
- WSAGETSELECTERRO
- WSAGETASYNCERRO
- EBADEXEC
- WSAEFAULT
- WSAELOOP
- WSAGETASYNCBUFLE
- WSAEMFILE
- WSAEDISCON
- ENOTACTIVE
- EAUTH
- WSAESOCKTNOSUPPORT
- EPROCUNAVAIL
- WSAMAKEASYNCREPL
- WSAEDQUOT
- ENEEDAUTH
- WSAENOBUFS
- WSAETOOMANYREFS
- WSAEOPNOTSUPP
- WSAENOTSOCK
- WSASYSNOTREADY
- WSAEPROTONOSUPPORT
- ENOTSUP
- WSAMAKESELECTREPL
- ELOCKUNMAPPED
- EBADMACHO
- WSAN
- WSAENAMETOOLONG
- WSAEMSGSIZE
- ENOPOLICY
- WSAEINPROGRESS
- WSAENETUNREACH
- WSAEACCES
- WSAENOTCONN
- EBADRPC
- EFTYPE
- WSADESCRIPTIO
- ERPCMISMATCH
- ENOATTR
- WSAECONNRESET
- WSAESTALE
- WSAGETSELECTEVEN
- EPWROFF
- WSASY
- WSATR
- WSAEINVAL
- WSAESHUTDOWN
- WSAENETRESET
- EDEVERR
- EPROGMISMATCH
- WSAENETDOWN
- WSAEDESTADDRREQ
- ESHLIBVERS
- WSAEAFNOSUPPORT
- WSAEWOULDBLOCK
- WSAEHOSTUNREACH
| Operation not possible due to RF-kill | ||
|
|
||
|
|
||
| .. data:: EHWPOISON |
There was a problem hiding this comment.
This one is not present in Modules/errnomodule.c
There was a problem hiding this comment.
thanks, added EHWPOISON
|
@remilapeyre I think the reason those missing errors were not added is because they are alias for linux errno, for e.g. windows |
What about |
|
@remilapeyre Yes, i was just looking at those and other os specific |
|
I also tried adding missing windows error description but they are not really that useful to users like e.g. |
I don't know Windows well but I think you will find more information in the documentation e.g. https://docs.microsoft.com/en-us/windows/win32/winsock/windows-sockets-error-codes-2 Could we add subsections like "Those errors are specific to MacOS:"? It would break the long list and make it easier to ignore the parts of the list not applicable to our current platform. |
|
@remilapeyre I have updated what description i could find. I have been adding WSATR |
remilapeyre
left a comment
There was a problem hiding this comment.
Thanks for making the changes @YoSTEALTH ! A core developer will make another review and answer your question.
That's rather verbose, but okay IMO on a page like this which is a very technical list. I'd still suggest breaking up the already very long list, similar to how it is in the source code file, putting OS-specific codes in separate sub-sections. |
|
With the addition of We don't detail doc-only changes in NEWS, so the NEWS entry should only mention the addition of |
|
@taleinat ok, thanks for your comments, I will get to these changes on/before this coming weekend. |
|
Could this be merged as is for now? Will create new PR for other changes. |
|
@YoSTEALTH Could you solve the conflicts? |
Only mentioning the addition of `EHWPOISON`
|
I am not sure whats going on. I just don't have the time + proper setup to deal with coding issues anymore. If this issues doesn't get resolved soon, I am just going to close this PR, as is been many years. |
https://bugs.python.org/issue40869