Skip to content

bpo-30681: Support invalid date format or value #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timb07 wants to merge 6 commits into from
Closed

bpo-30681: Support invalid date format or value #2254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2bf3127
bpo-30681: Change error handling to return None in case of invalid date
timb07 Jun 17, 2017
e0b616a
bpo-30681: Handle invalid date in Date header
timb07 Jun 17, 2017
c59e0bf
bpo-30681: Add InvalidDateDefect
timb07 Jun 17, 2017
5c6cfaf
Revert "bpo-30681: Change error handling to return None in case of in…
timb07 Jun 17, 2017
8c8ac38
bpo-30681: Handle invalid date in Date header
timb07 Nov 28, 2018
96f8223
bpo-30681: Document failure modes of parsedate_to_datetime and add tests
timb07 Nov 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bpo-30681: Document failure modes of parsedate_to_datetime and add tests
  • Loading branch information
@timb07
timb07 committed Nov 28, 2018
commit 96f82236397be9d0d3f62ef9b8c51e2d41feafe9
5 changes: 4 additions & 1 deletion Doc/library/email.util.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ of the new API.
.. function:: parsedate_to_datetime(date)

The inverse of :func:`format_datetime`. Performs the same function as
:func:`parsedate`, but on success returns a :mod:`~datetime.datetime`. If
:func:`parsedate`, but on success returns a :mod:`~datetime.datetime`;
otherwise ``None`` may be returned if parsing fails, or a ``ValueError``
raised if *date* contains an invalid value such as an hour greater than
23 or a timezone offset not between -24 and 24 hours. If
the input date has a timezone of ``-0000``, the ``datetime`` will be a naive
``datetime``, and if the date is conforming to the RFCs it will represent a
time in UTC but with no indication of the actual source timezone of the
Expand Down
16 changes: 16 additions & 0 deletions Lib/test/test_email/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,22 @@ def test_parsedate_to_datetime_naive(self):
utils.parsedate_to_datetime(self.datestring + ' -0000'),
self.naive_dt)

def test_parsedate_to_datetime_with_invalid_raises_typeerror(self):
with self.assertRaises(TypeError):
utils.parsedate_to_datetime('')
with self.assertRaises(TypeError):
utils.parsedate_to_datetime('0')
with self.assertRaises(TypeError):
utils.parsedate_to_datetime('A Complete Waste of Time')

def test_parsedate_to_datetime_with_invalid_raises_valueerror(self):
with self.assertRaises(ValueError):
utils.parsedate_to_datetime('Tue, 06 Jun 2017 27:39:33 +0600')
with self.assertRaises(ValueError):
utils.parsedate_to_datetime('Tue, 06 Jun 2017 07:39:33 +2600')
with self.assertRaises(ValueError):
utils.parsedate_to_datetime('Tue, 06 Jun 2017 27:39:33')


class LocaltimeTests(unittest.TestCase):

Expand Down