gh-88037: Move port validation logic to parsing time#25774
Open
miguendes wants to merge 1 commit intopython:mainfrom
Open
gh-88037: Move port validation logic to parsing time#25774miguendes wants to merge 1 commit intopython:mainfrom
miguendes wants to merge 1 commit intopython:mainfrom
Conversation
7cf9ace to
cf3913e
Compare
|
This PR is stale because it has been open for 30 days with no activity. |
akulakov
reviewed
Jun 27, 2021
akulakov
reviewed
Jun 27, 2021
akulakov
reviewed
Jun 27, 2021
5ebd099 to
3419baa
Compare
Contributor
|
Any update on this? I need this behavior, and have implemented a fix myself. Should I submit another PR? |
Member
@kenballus indeed, looks like this one has stalled. a new up to date PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43871