bpo-45172: netbsd socketmodule CAN protocol constants addition.#28288
bpo-45172: netbsd socketmodule CAN protocol constants addition.#28288devnexen wants to merge 4 commits intopython:mainfrom
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
|
This looks alright. Perhaps a test would be good. @vstinner could you have a look? |
Modules/socketmodule.c
Outdated
There was a problem hiding this comment.
Maybe move CAN_RAW_ERR_FILTER above in a separated block to avoid nested #if.
b3dd0be to
799d8e1
Compare
|
well tests are based on the presence of constants existence and netbsd share the same naming. |
|
🤖 New build scheduled with the buildbot fleet by @ambv for commit 799d8e13b2653916ced73ee9855ed2a61c841117 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
erlend-aasland
left a comment
There was a problem hiding this comment.
@devnexen, can you resolve conflicts and address Victor's review?
799d8e1 to
cfff139
Compare
cfff139 to
7113d49
Compare
|
Please avoid force-pushing PRs. I'm now unable to see the changes between your first version of the PR and the new version. It makes the reviewers job easier if you use |
erlend-aasland
left a comment
There was a problem hiding this comment.
Looks good to me. If Victor gives a thumbs up, I'll merge in a day or two.
vstinner
left a comment
There was a problem hiding this comment.
LGTM. @erlend-aasland: you can merge it if you're fine with the current NEWS entry.
Misc/NEWS.d/next/Library/2021-09-11-13-45-47.bpo-45172.T0LUgT.rst
Outdated
Show resolved
Hide resolved
Thanks, I'll merge after the NEWS entry has been amended. |
|
I updated the entry accordingly. |
|
It looks like gh-30066 already added support for the |
|
Ah I did not notice that one, well if this is supported already then my PR is pointless now. |
|
Nonetheless, thanks for your interest in improving CPython :) |
|
Well, the important thing is that Python got CAN support on NetBSD ;-) 40fcd16 is part of Python 3.11: you can test the beta1! Yeah, thanks for your interest in enhancing Python! |
https://bugs.python.org/issue45172