bpo-46072: Add detailed failure stats for BINARY_OP#31289
Merged
brandtbucher merged 5 commits intopython:mainfrom Feb 16, 2022
Merged
bpo-46072: Add detailed failure stats for BINARY_OP#31289brandtbucher merged 5 commits intopython:mainfrom
BINARY_OP#31289brandtbucher merged 5 commits intopython:mainfrom
Conversation
Member
|
This looks like it adds some overhead when not gathering stats. default:
SPECIALIZATION_FAIL(BINARY_OP, binary_op_failure_kind(lhs, rhs)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On further reflection, I think it's definitely possible to get our current ~80% hit rate up to ~90%. These detailed failure stats will help guide my work on this.
Example full
pyperformancerun with this patch applied:Specialization attempts
Note that "add other" and "multiply different types" also correspond more specifically to sequence concatenation and repetition, respectively. Similarly, "remainder" probably contains many examples of old-style string formatting.
I figure it's not worth the clutter of breaking out specific stats for these non-numeric cases yet, since their proportion of the total failures is still pretty low (and the benefit of specialization seems slim).
https://bugs.python.org/issue46072