Skip to content

bpo-39829: Optimize __len__() being called twice in the list() constructor #31816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 15 commits into from
Mar 14, 2022
+14 −18
Merged

bpo-39829: Optimize __len__() being called twice in the list() constructor #31816

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0a5d672
bpo-39829: __len__() called twice in the list() constructor
thatbirdguythatuknownot Mar 8, 2022
ac00535
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 8, 2022
12eba03
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 8, 2022
fc50d36
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 8, 2022
37382e8
bpo-43574 + bpo-39829: Optimize allocations
thatbirdguythatuknownot Mar 8, 2022
4b96319
bpo-43574 + bpo-39829: Optimize list allocations
thatbirdguythatuknownot Mar 9, 2022
ecb8c89
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 9, 2022
66c0246
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 9, 2022
1f706b4
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 9, 2022
75ec222
bpo-39829: __len__() called twice when constructing a list
thatbirdguythatuknownot Mar 10, 2022
b5841b9
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 10, 2022
e08c426
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 11, 2022
0eb2871
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 11, 2022
39b88e3
bpo-39829: __len__() called twice in the list() constructor
thatbirdguythatuknownot Mar 11, 2022
ad547f5
bpo-39829: __len__ called twice in the list() constructor
thatbirdguythatuknownot Mar 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-39829: __len__ called twice in the list() constructor
  • Loading branch information
@thatbirdguythatuknownot
thatbirdguythatuknownot authored Mar 8, 2022
commit 12eba0364b67fb0d75d372b2c06ab1126cb79574
8 changes: 3 additions & 5 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -895,11 +895,9 @@ list_extend(PyListObject *self, PyObject *iterable)
return NULL;
}
}
else {
if (list_resize(self, m + n) < 0) {
Py_DECREF(iterable);
return NULL;
}
else if (list_resize(self, m + n) < 0) {
Py_DECREF(iterable);
return NULL;
}
/* note that we may still have self == iterable here for the
* situation a.extend(a), but the following code works
Expand Down