Skip to content

[skip issue]Small changes in importing process of multiprocessing package #6856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 5 commits into from
Jul 11, 2018
Merged

[skip issue]Small changes in importing process of multiprocessing package #6856

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
02c298d
Changed unnecessarily complex way of updating of __all__ and globals …
May 15, 2018
eb07cb5
Maybe a misguiding comment
May 15, 2018
25335c3
Added a trivial test for __all__
Jun 1, 2018
ef222ac
Trivial error fixed
Jul 3, 2018
2e617a2
__all__ is not supposed to be modified
Jul 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Maybe a misguiding comment
  • Loading branch information
Derek Kim committed May 15, 2018
commit eb07cb545f3e3ed5708edf5dee4591d6f89df470
2 changes: 1 addition & 1 deletion Lib/multiprocessing/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
from . import process
from . import reduction

__all__ = [] # things are copied from here to __init__.py
__all__ = []
Copy link
Copy Markdown
Member

@methane methane Jun 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use __all__ = ()? Or __all__ is modified later?

Copy link
Copy Markdown
Contributor Author

@bombs-kim bombs-kim Jun 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's modified. I will run the test and tell you the result

Copy link
Copy Markdown
Contributor Author

@bombs-kim bombs-kim Jul 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@methane I updated things that you pointed out. It passed all tests. Thanks.


#
# Exceptions
Expand Down