Skip to content

bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in parallel#7468

Merged
1st1 merged 1 commit intopython:masterfrom
1st1:fix_ag_running
Sep 30, 2019
Merged

bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in parallel#7468
1st1 merged 1 commit intopython:masterfrom
1st1:fix_ag_running

Conversation

@1st1
Copy link
Member

@1st1 1st1 commented Jun 7, 2018 •
edited by bedevere-bot
Loading

@1st1 1st1 requested a review from asvetlov as a code owner June 7, 2018 05:02
@1st1 1st1 requested a review from njsmith June 7, 2018 05:02
dimaqq
dimaqq reviewed Jun 7, 2018
View reviewed changes
@asvetlov
Copy link
Contributor

asvetlov commented Sep 13, 2019

Could you resolve conflicts please?
I'd like to checkout your branch and play with it locally.

@1st1
Copy link
Member Author

1st1 commented Sep 20, 2019

Could you resolve conflicts please?
I'd like to checkout your branch and play with it locally.

Done!

asvetlov
asvetlov reviewed Sep 21, 2019
View reviewed changes
@asvetlov
Copy link
Contributor

asvetlov commented Sep 27, 2019

@1st1 the PR looks good after fixing a couple comments

@1st1
Copy link
Member Author

1st1 commented Sep 28, 2019

@1st1 the PR looks good after fixing a couple comments

Thanks, will fix it and commit soon.

@1st1 1st1 merged commit fc4a044 into python:master Sep 30, 2019
@1st1 1st1 deleted the fix_ag_running branch September 30, 2019 05:59
@miss-islington
Copy link
Contributor

miss-islington commented Sep 30, 2019

Thanks @1st1 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2019

@1st1: Please replace # with GH- in the commit message next time. Thanks!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2019
@1st1 @miss-islington
bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in pa…
60d38b1 
…rallel (pythonGH-7468)

(cherry picked from commit fc4a044)

Co-authored-by: Yury Selivanov <yury@magic.io>
@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2019

GH-16486 is a backport of this pull request to the 3.8 branch.

1st1 added a commit that referenced this pull request Sep 30, 2019
@miss-islington @1st1
bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in pa…
2f87a7d 
…rallel (GH-7468) (#16486)

(cherry picked from commit fc4a044)

Co-authored-by: Yury Selivanov <yury@magic.io>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@1st1
bpo-30773: Fix ag_running; prohibit running athrow/asend/aclose in pa…
29f37e7 
…rallel (python#7468)
@dimaqq dimaqq mannequin mentioned this pull request Apr 10, 2022
Closed
@graingert graingert mentioned this pull request Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov left review comments

@njsmith njsmith Awaiting requested review from njsmith

+1 more reviewer

@dimaqq dimaqq dimaqq left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@1st1 @asvetlov @miss-islington @bedevere-bot @dimaqq @the-knights-who-say-ni