bpo-33855: Minimally test all IDLE modules. by terryjreedy · Pull Request #7689 · python/cpython

terryjreedy · 2018-06-14T07:20:05Z

for implementation module in idlelib modules:
    if test_module not in idle_test:
        create test_module from template.py;   add 'module' to docstring
        import module and check other minimal imports
        create instance of each class, with requires('gui') if needed
        add initial coverage of this test
        add test invocation to module
    else:
        check same for existing test

https://bugs.python.org/issue33855

willingc

Thanks @terryjreedy. I noticed one possible typo. LGTM.

willingc · 2018-06-14T13:22:31Z

Lib/idlelib/idle_test/template.py

+from test.support import requires
+from tkinter import Tk
+
+import


I don't see a misspelling. The name of the tested module goes after Test above and after import. I can see how this might not be clear if you did not write it ;-). But all idlelib module imports need from idlelib prefixed, so I added that.

So let me make sure that I understand, you have import as a placeholder for someone writing a test for a module (say "xyz"). Folks would copy the template, change the file's name to test_xyz.py. Inside the file a person writing tests would insert xyz as:

Test xyz coverage %. ... import xyz

Just clarifying that an import statement without a module name isn't planned to be executed. (If I'm missing the boat, and you can execute import without a . or module name, please let me know since I didn't think one could do this).

Perhaps it would be clearer to name the file test_modname.py.template, and insert modname where the module name should go rather than leaving blanks. From a UNIX perspective, this would allow one to do sed 's/modname/real_mod_name/g' test_modname.py.template > test_real_mod_name.py to create the test file from the template in one step.

Windows does not have sed, and for two insertions, it is not worth the trouble. The name 'template.py' puts the file just above the first test_a.py file, making it initially visible in IDLE's open dialog and easy to find, and automatically 'saved as' a .py file.

I am the initial user of the file, for this issue. It standardizes the header and footer lines and documents some of the setup and teardown needed for gui tests. (I just discovered and added a new trick for EditorWindow.) I intend to discuss it, along with other gui-testing tricks not part of the template, in the README.

Prevent tcl event warning on shutdown

Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es). Add a test file for all non-startup IDLE modules. Edit existing files and update coverage. This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files. (cherry picked from commit ee5ef30) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot · 2018-06-15T22:22:08Z

GH-7731 is a backport of this pull request to the 3.7 branch.

miss-islington · 2018-06-15T22:23:00Z

Sorry, @terryjreedy, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ee5ef309c7e2daef1248730145408f700732c42e 3.6

Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es). Add a test file for all non-startup IDLE modules. Edit existing files and update coverage. This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files. (cherry picked from commit ee5ef30) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es). Add a test file for all non-startup IDLE modules. Edit existing files and update coverage. This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files.. (cherry picked from commit ee5ef30) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

bedevere-bot · 2018-06-15T22:51:48Z

GH-7734 is a backport of this pull request to the 3.6 branch.

Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es). Add a test file for all non-startup IDLE modules. Edit existing files and update coverage. This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files.. (cherry picked from commit ee5ef30) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Part 2 of 3. Continues PR pythonGH-7689, changeset ee5ef30. Edit and add tests for 18 modules, help_about to replace and run. (cherry picked from commit ea3dc80) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Part 2 of 3. Continues PR #7689, changeset ee5ef30. Edit and add tests for 18 modules, help_about to replace and run.

Part 2 of 3. Continues PR GH-7689, changeset ee5ef30. Edit and add tests for 18 modules, help_about to replace and run. (cherry picked from commit ea3dc80) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Part 3 of 3, continuing PR pythonGH-7689. This covers 14 idlelib modules and their tests, rpc to zoomheight except for run (already done) and tooltip (being done separately). (cherry picked from commit 4d92158) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Part 3 of 3, continuing PR #7689. This covers 14 idlelib modules and their tests, rpc to zoomheight except for run (already done) and tooltip (being done separately).

Part 3 of 3, continuing PR GH-7689. This covers 14 idlelib modules and their tests, rpc to zoomheight except for run (already done) and tooltip (being done separately). (cherry picked from commit 4d92158) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>

Create a template for minimally testing a tkinter-using module by importing it and instantiating its class(es). Add a test file for all non-startup IDLE modules. Edit existing files and update coverage. This is part 1 of 3, covering the 21 autocomplete to help modules and touching 33 idlelib files. (cherry picked from commit ee5ef30) # Conflicts fixed: # Lib/idlelib/idle_test/test_calltip.py

terryjreedy added 7 commits June 13, 2018 23:17

Edit test_autocomplete.

0d3dcc1

Edit test_autocomplete.

f819957

Add test_autocomplete_w.

a661e32

Edit autocomplete_w.py.

858d9d4

Edit test_calltips.

b011fd3

Add idle_test/template.py.

3f4e9cf

Edit test_autoexpand.

4572cde

the-knights-who-say-ni added the CLA signed label Jun 14, 2018

bedevere-bot added the awaiting merge label Jun 14, 2018

terryjreedy changed the title ~~bpo-33855: Minimally test all IDLE files.~~ bpo-33855: Minimally test all IDLE modules. Jun 14, 2018

terryjreedy added needs backport to 3.6 tests Tests in the Lib/test dir labels Jun 14, 2018

terryjreedy self-assigned this Jun 14, 2018

willingc reviewed Jun 14, 2018

View reviewed changes

terryjreedy added 15 commits June 14, 2018 11:36

Add blurb.

c19d810

Edit test_browser.

dedc726

Edit template.

8658eab

Edit template.

59b504b

Edit template.

23375c7

Add test_calltip_w.py.

3d23f61

Edit tests for codecontext, colorizer, config, and config_key.

c0328ce

Edit test_calltips.

d764c73

Move tested module import first.

9248976

Edit template and test_autocomple_w.

ce7c113

Prevent tcl event warning on shutdown

templage whitespace

bc81598

Edit test_configdialog and test_debugger.

ad6232f

Edit autocomplete, autocomplete_w, calltip_w, colorizer.

e3b77a1

Add test_debugger_r, edit test_debugger, debugger, debugger_r.

126d2d0

Edit debugobj, debugobj_r, add test_debugobj, test_debugobj_r.

5a81d36

terryjreedy deleted the moretests branch June 15, 2018 22:21

bedevere-bot removed the needs backport to 3.7 label Jun 15, 2018

bedevere-bot removed the needs backport to 3.6 label Jun 15, 2018

terryjreedy mentioned this pull request Jun 17, 2018

bpo-33855: More edits and new minimal tests for IDLE #7761

Merged

miss-islington mentioned this pull request Jun 18, 2018

[3.7] bpo-33855: More edits and new minimal tests for IDLE (GH-7761) #7774

Merged

miss-islington mentioned this pull request Jun 18, 2018

[3.6] bpo-33855: More edits and new minimal tests for IDLE (GH-7761) #7775

Merged

terryjreedy added a commit that referenced this pull request Jun 18, 2018

bpo-33855: More edits and new minimal tests for IDLE (GH-7761)

ea3dc80

Part 2 of 3. Continues PR #7689, changeset ee5ef30. Edit and add tests for 18 modules, help_about to replace and run.

terryjreedy mentioned this pull request Jun 19, 2018

bpo-33855: Still more edits and minimal tests for IDLE #7784

Merged

miss-islington mentioned this pull request Jun 19, 2018

[3.7] bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) #7805

Merged

miss-islington mentioned this pull request Jun 19, 2018

[3.6] bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) #7806

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

bpo-33855: Minimally test all IDLE modules.#7689

bpo-33855: Minimally test all IDLE modules.#7689
terryjreedy merged 30 commits intopython:masterfrom
terryjreedy:moretests

terryjreedy commented Jun 14, 2018 •

edited

Loading

Uh oh!

willingc left a comment

Uh oh!

willingc Jun 14, 2018

Uh oh!

terryjreedy Jun 14, 2018 •

edited

Loading

Uh oh!

willingc Jun 14, 2018

Uh oh!

zware Jun 14, 2018

Uh oh!

terryjreedy Jun 15, 2018

Uh oh!

bedevere-bot commented Jun 15, 2018

Uh oh!

miss-islington commented Jun 15, 2018

Uh oh!

bedevere-bot commented Jun 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

terryjreedy commented Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

willingc left a comment

Choose a reason for hiding this comment

Uh oh!

willingc Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

terryjreedy Jun 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

willingc Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

zware Jun 14, 2018

Choose a reason for hiding this comment

Uh oh!

terryjreedy Jun 15, 2018

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Jun 15, 2018

Uh oh!

miss-islington commented Jun 15, 2018

Uh oh!

bedevere-bot commented Jun 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

terryjreedy commented Jun 14, 2018 •

edited

Loading

terryjreedy Jun 14, 2018 •

edited

Loading