Skip to content

bpo-33451: Close .pyc files before calling PyEval_EvalCode()#7884

Merged
ncoghlan merged 2 commits intopython:masterfrom
ZackerySpytz:bpo-33451-close-pyc-before-evaluating
Jun 24, 2018
Merged

bpo-33451: Close .pyc files before calling PyEval_EvalCode()#7884
ncoghlan merged 2 commits intopython:masterfrom
ZackerySpytz:bpo-33451-close-pyc-before-evaluating

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Jun 23, 2018 •
edited by bedevere-bot
Loading

.pyc files were kept open longer than necessary.

https://bugs.python.org/issue33451

@ZackerySpytz
bpo-33451: Close .pyc files before calling PyEval_EvalCode()
0de9c81 
.pyc files were kept open longer than necessary.
ncoghlan
ncoghlan approved these changes Jun 24, 2018
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I explicitly checked that run_pyc_file is a private helper function inside pythonrun.c, so there's no externally visible change in behaviour other than the intended one of closing the pyc file before we start executing the code)

@ncoghlan ncoghlan merged commit ea73775 into python:master Jun 24, 2018
@miss-islington
Copy link
Contributor

miss-islington commented Jun 24, 2018

Thanks @ZackerySpytz for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jun 24, 2018

Thanks @ZackerySpytz for the PR, and @ncoghlan for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 24, 2018

GH-7888 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2018
@ZackerySpytz @miss-islington
bpo-33451: Close pyc files before calling PyEval_EvalCode() (pythonGH…
4108ce8 
…-7884)

Directly executed pyc files were being kept open longer than necessary.
(cherry picked from commit ea73775)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 24, 2018

GH-7889 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2018
@ZackerySpytz @miss-islington
bpo-33451: Close pyc files before calling PyEval_EvalCode() (pythonGH…
3da1734 
…-7884)

Directly executed pyc files were being kept open longer than necessary.
(cherry picked from commit ea73775)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jun 24, 2018
@miss-islington @ZackerySpytz
bpo-33451: Close pyc files before calling PyEval_EvalCode() (GH-7884)
56aaef0 
Directly executed pyc files were being kept open longer than necessary.
(cherry picked from commit ea73775)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jun 24, 2018
@miss-islington @ZackerySpytz
bpo-33451: Close pyc files before calling PyEval_EvalCode() (GH-7884)
8f8ad2c 
Directly executed pyc files were being kept open longer than necessary.
(cherry picked from commit ea73775)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@ZackerySpytz ZackerySpytz deleted the bpo-33451-close-pyc-before-evaluating branch June 25, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ZackerySpytz @miss-islington @bedevere-bot @ncoghlan @the-knights-who-say-ni