Skip to content

gh-90667: fix incompatible pointer type warnings#91822

Closed
erlend-aasland wants to merge 1 commit intopython:mainfrom
erlend-aasland:fix-decref-warnings
Closed

gh-90667: fix incompatible pointer type warnings#91822
erlend-aasland wants to merge 1 commit intopython:mainfrom
erlend-aasland:fix-decref-warnings

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 22, 2022

No description provided.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 22, 2022

Alternatively, we can fix the callers.

@sweeneyde
Copy link
Member

sweeneyde commented Apr 22, 2022

Out of curiosity, what does the compiler warning say?

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 22, 2022

Out of curiosity, what does the compiler warning say?

It's the GitHub CI that complains about incompatible pointer type -Wincompatible-pointer-types.

Screenshot

bilde

sweeneyde
sweeneyde approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@sweeneyde sweeneyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine, I'm just confused why I'm not seeing the compiler warnings anywhere on other PRs.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 24, 2022 •
edited
Loading

The change looks fine, I'm just confused why I'm not seeing the compiler warnings anywhere on other PRs.

I accidentally noticed it in GH-30872. I haven't checked other PRs yet, but I suspect it will only appear on PRs that either touch longobject.c or ceval.c. I'll have a look, FWIW.

UPDATE: I'm also seeing them in Victor's PR #91730. However, they are absent in Guido's recent ceval.c PRs. Not sure why, though.

@sweeneyde
Copy link
Member

sweeneyde commented Apr 24, 2022

Could it be that some of these have been fixed by #91711?

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 24, 2022

Could it be that some of these have been fixed by #91711?

Ah, that passed me by; sorry for the noise. I'll close this, then.

@erlend-aasland erlend-aasland deleted the fix-decref-warnings branch April 24, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneyde sweeneyde sweeneyde approved these changes

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@erlend-aasland @sweeneyde @bedevere-bot