gh-91832: Fix 'required' attribute not showing up in repr of argparse…#91840
gh-91832: Fix 'required' attribute not showing up in repr of argparse…#91840fatihkabakk wants to merge 3 commits intopython:mainfrom
Conversation
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
|
All set thanks |
|
Working on fixing the argparse test failure. |
|
Updated the tests, all passed on local Ubuntu! |
… the updated library
660cadd to
acdbc78
Compare
However, when I fix test file it needs |
|
I checked the last commit on this file(test_argparse.py). It was eafec26 , it doesn't seem like the same issue occurred there. So, we might have to check if make patchcheck has somehow changed recently. I can't see the output of that commit's build either. So can't look into it for any clue. |
But internal names could be picked up by mistake, so an explicit list seems fine to me. Thanks for the PR. Because the code here is the same as #91841, I am closing this one so that reviews and approvals stay in one place. The contribution is appreciated nonetheless! |
Closes #91832
Also there is another solution to just use
self.__dict__and ignorecontainer, it gives the same list and seems to be better than creating and updating the list manually.If
self.__dict__usage would be approved, I am volunteer to do the necessary change(s).