Skip to content

GH-90690: Remove PRECALL instruction #92925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 2 commits into from
May 19, 2022
Merged

GH-90690: Remove PRECALL instruction #92925

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d937ef
Remove PRECALL instruction.
markshannon May 18, 2022
bad98cf
Add news and remove PRECALL from docs.
markshannon May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add news and remove PRECALL from docs.
  • Loading branch information
@markshannon
markshannon committed May 18, 2022
commit bad98cf66dbd467da21e2bf52afb7c9cb265ea00
17 changes: 3 additions & 14 deletions Doc/library/dis.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,8 @@ the following command can be used to display the disassembly of
2 2 PUSH_NULL
4 LOAD_GLOBAL 1 (NULL + len)
6 LOAD_FAST 0 (alist)
8 PRECALL 1
10 CALL 1
12 RETURN_VALUE
8 CALL 1
18 RETURN_VALUE

(The "2" is a line number).

Expand Down Expand Up @@ -119,7 +118,6 @@ Example::
PUSH_NULL
LOAD_GLOBAL
LOAD_FAST
PRECALL
CALL
RETURN_VALUE

Expand Down Expand Up @@ -1182,15 +1180,6 @@ iterations of the loop.
.. versionadded:: 3.7


.. opcode:: PRECALL (argc)

Prefixes :opcode:`CALL`. Logically this is a no op.
It exists to enable effective specialization of calls.
``argc`` is the number of arguments as described in :opcode:`CALL`.

.. versionadded:: 3.11


.. opcode:: PUSH_NULL

Pushes a ``NULL`` to the stack.
Expand All @@ -1202,7 +1191,7 @@ iterations of the loop.

.. opcode:: KW_NAMES (i)

Prefixes :opcode:`PRECALL`.
Prefixes :opcode:`CALL`.
Stores a reference to ``co_consts[consti]`` into an internal variable
for use by :opcode:`CALL`. ``co_consts[consti]`` must be a tuple of strings.

Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-05-18-12-55-35.gh-issue-90690.TKuoTa.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The PRECALL instruction has been removed. It offered only a small advantage
for specialization and is not needed in the vast majority of cases.