Skip to content

gh-93771: Clarify how deepfreeze.py is run #94150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
Jun 23, 2022
Merged

gh-93771: Clarify how deepfreeze.py is run #94150

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d895840
Clarify how deepfreeze.py is run
gvanrossum Jun 23, 2022
3a77a8f
Fix typo
gvanrossum Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
  • Loading branch information
@gvanrossum @corona10
gvanrossum and corona10 authored Jun 23, 2022
commit 3a77a8ffb63a008a1d7d719edb1e0874b4fc4d3a
2 changes: 1 addition & 1 deletion Tools/scripts/deepfreeze.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
The script may be executed by _bootstrap_python interpreter.
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, another thing is that even though this script is executed by _bootstrap_python with the same magic number, still it uses umarshal rather than directly using compile even though it supports both but I suppose that it would be too much info to add.

Copy link
Copy Markdown
Member Author

@gvanrossum gvanrossum Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that code could even be removed?

Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That code is useful as sometimes I used it to debug marshal output so better to leave as is.

Copy link
Copy Markdown
Member Author

@gvanrossum gvanrossum Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that's fine.

Shared library extension modules are not available in that case.
On Windows, and in cross-compilation cases, it is executed
by Python 3.10, and 3.11 features are not avaiable.
by Python 3.10, and 3.11 features are not available.
"""
import argparse
import ast
Expand Down