Skip to content

[3.11] GH-93516: Drop broken assert, fixes GH-93769 #94411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 1 commit into from
Jun 29, 2022
Merged

[3.11] GH-93516: Drop broken assert, fixes GH-93769 #94411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[3.11] GH-93516: Drop broken assert, fixes GH-93769 
The ``assert`` is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be ``_PyOpcode_Deopt[_Py_OPCODE(...)]`` instead of
``_PyOpcode_Deopt[...]``.
  • Loading branch information
@tiran
tiran committed Jun 29, 2022
commit 8fd8bc4f2640b6f4881d0debe29056cee38825b3
4 changes: 0 additions & 4 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5611,10 +5611,6 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, _PyInterpreterFrame *frame, int
if (tstate->tracing == 0 &&
INSTR_OFFSET() >= frame->f_code->_co_firsttraceable
) {
assert(
_PyOpcode_Deopt[first_instr[frame->f_code->_co_firsttraceable]]
== RESUME
);
int instr_prev = _PyInterpreterFrame_LASTI(frame);
frame->prev_instr = next_instr;
TRACING_NEXTOPARG();
Expand Down