Skip to content

gh-94603: micro optimize list.pop #94604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 17 commits into from
Dec 27, 2022
Merged

gh-94603: micro optimize list.pop #94604

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
79ac0ff
optimize list.pop
eendebakpt Jul 6, 2022
4cf3c19
📜🤖 Added by blurb_it.
blurb-it[bot] Jul 6, 2022
4db7ec5
fix news item
eendebakpt Jul 6, 2022
1512885
Update Objects/listobject.c
eendebakpt Jul 8, 2022
58e38d6
Update Objects/listobject.c
eendebakpt Jul 10, 2022
e55907c
Merge branch 'main' into performance/list_pop
eendebakpt Jul 26, 2022
a97f93e
Merge branch 'main' into performance/list_pop
eendebakpt Jul 28, 2022
a711050
Merge branch 'main' into performance/list_pop
eendebakpt Aug 10, 2022
b1ebb5c
Merge branch 'main' into performance/list_pop
eendebakpt Aug 22, 2022
12411a9
Merge branch 'main' into performance/list_pop
eendebakpt Sep 19, 2022
8940af7
Merge branch 'main' into performance/list_pop
eendebakpt Oct 19, 2022
9635cfe
Merge branch 'main' into performance/list_pop
eendebakpt Nov 9, 2022
91afa40
Merge branch 'main' into performance/list_pop
eendebakpt Dec 22, 2022
44a4efe
Apply suggestions from code review
eendebakpt Dec 26, 2022
7c6c9fa
rename to size_after_pop
eendebakpt Dec 26, 2022
7c1a835
make variable const
eendebakpt Dec 26, 2022
23eb3aa
Update Objects/listobject.c
corona10 Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update Objects/listobject.c 
Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
  • Loading branch information
@eendebakpt @corona10
eendebakpt and corona10 authored Jul 8, 2022
commit 1512885e242707ba2aa84346e410316d61bc5730
5 changes: 3 additions & 2 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1052,8 +1052,9 @@ list_pop_impl(PyListObject *self, Py_ssize_t index)
memmove(&items[index], &items[index+1], (Py_SIZE(self)-1-index)* sizeof(PyObject *));
status = list_resize(self, Py_SIZE(self) - 1);
}
if (status >= 0)
return v; /* and v now owns the reference the list had */
if (status >= 0) {
return v; // and v now owns the reference the list had
}
else {
// list resize failed, need to restore
memmove(&items[index+1], &items[index], (Py_SIZE(self)-1-index)* sizeof(PyObject *));
Expand Down