[3.11] gh-91181: drop support for bytes on sys.path (GH-31934)#94914
Merged
miss-islington merged 1 commit intopython:3.11from Jul 17, 2022
Merged
[3.11] gh-91181: drop support for bytes on sys.path (GH-31934)#94914miss-islington merged 1 commit intopython:3.11from
miss-islington merged 1 commit intopython:3.11from
Conversation
Support for bytes broke sometime between Python 3.2 and 3.6 and has been broken ever since. Trying to bring back supports is surprisingly difficult in the face of -b and checking for keys in sys.path_importer_cache. Since the support was broken for so long, trying to overcome the difficulty of bringing back the support has been deemed not worth it. Co-authored-by: Eryk Sun <eryksun@gmail.com> Co-authored-by: Brett Cannon <brett@python.org> (cherry picked from commit 6da988a) Co-authored-by: Thomas Grainger <tagrain@gmail.com>
Contributor
Author
|
Status check is done, and it's a success ✅ . |
Contributor
Author
|
Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
Status check is done, and it's a success ✅ . |
brettcannon
approved these changes
Jul 17, 2022
Contributor
Author
|
Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for bytes broke sometime between Python 3.2 and 3.6 and has been broken ever since. Trying to bring back supports is surprisingly difficult in the face of -b and checking for keys in sys.path_importer_cache. Since the support was broken for so long, trying to overcome the difficulty of bringing back the support has been deemed not worth it.
Co-authored-by: Eryk Sun eryksun@gmail.com
Co-authored-by: Brett Cannon brett@python.org
(cherry picked from commit 6da988a)
Co-authored-by: Thomas Grainger tagrain@gmail.com
Automerge-Triggered-By: GH:brettcannon