Skip to content

gh-95174: WASI: skip missing sockets functions (GH-95179)#95179

Merged
tiran merged 2 commits intopython:mainfrom
tiran:gh-95174-socket
Jul 27, 2022
Merged

gh-95174: WASI: skip missing sockets functions (GH-95179)#95179
tiran merged 2 commits intopython:mainfrom
tiran:gh-95174-socket

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jul 23, 2022 •
edited by brettcannon
Loading

WASI can only create sockets from an existing file descriptor. Hostname
lookups are not available.

  • check for missing sys/socket.h functions
  • handle missing netdb.h functions

@tiran tiran added the needs backport to 3.11 only security fixes label Jul 23, 2022
@tiran tiran requested a review from a team as a code owner July 23, 2022 20:03
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 23, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 23, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit d391cfad9a4ee14a2efc228bc70cdb8c0d62db02 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 23, 2022
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 24, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 24, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 08c0117068395faa4a588a8202338861d842543c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 24, 2022
@tiran tiran force-pushed the gh-95174-socket branch 2 times, most recently from bb3692b to 3b8efe3 Compare July 24, 2022 11:18
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 24, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 24, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 3b8efe3374513544b7a34a686531f1ec3f7aea45 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 24, 2022
@tiran tiran force-pushed the gh-95174-socket branch from 3b8efe3 to df3bae5 Compare July 25, 2022 06:05
@tiran
pythongh-95174: WASI: skip missing sockets functions
98f53d2 
WASI can only create sockets from an existing file descriptor. Hostname
looks are not available.

- check for missing ``sys/socket.h`` functions
- handle missing ``netdb.h`` functions
@tiran tiran force-pushed the gh-95174-socket branch from df3bae5 to 98f53d2 Compare July 25, 2022 07:07
@tiran tiran mentioned this pull request Jul 25, 2022
Merged
@tiran
Copy link
Member Author

tiran commented Jul 25, 2022

I have moved some changes into GH-95229 to have a clean split between socket-related changes and other changes.

@tiran tiran requested a review from brettcannon July 25, 2022 13:31
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2022
@bedevere-bot
Copy link

bedevere-bot commented Jul 25, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 98f53d2 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 25, 2022
@tiran tiran changed the title gh-95174: WASI: skip missing sockets functions gh-95174: WASI: skip missing sockets functions (GH-95179) Jul 27, 2022
@tiran tiran merged commit 8b24d60 into python:main Jul 27, 2022
@tiran tiran deleted the gh-95174-socket branch July 27, 2022 06:19
@miss-islington
Copy link
Contributor

miss-islington commented Jul 27, 2022

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 27, 2022

Sorry, @tiran, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 8b24d60f1b7725d526ea5b5d3904b72e8b41ae0d 3.11

tiran added a commit to tiran/cpython that referenced this pull request Jul 27, 2022
@tiran
[3.11] pythongh-95174: WASI: skip missing sockets functions (pythonGH…
0788456 
…-95179).

(cherry picked from commit 8b24d60)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Jul 27, 2022

GH-95308 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 27, 2022
tiran added a commit that referenced this pull request Jul 31, 2022
@tiran @pablogsal
[3.11] gh-95174: WASI: skip missing sockets functions (GH-95179) (GH-…
06b5f78 
…95308)

Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@tiran tiran mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Assignees

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @bedevere-bot @miss-islington @brettcannon