gh-97955: Migrate zoneinfo to Argument Clinic#97958
Merged
ambv merged 1 commit intopython:mainfrom Oct 7, 2022
Merged
Conversation
blockchainGuru1018
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure that it is worth converting these functions:
{"utcoffset", (PyCFunction)zoneinfo_utcoffset, METH_O, PyDoc_STR("Retrieve a timedelta representing the UTC offset in a zone at " "the given datetime.")}, {"dst", (PyCFunction)zoneinfo_dst, METH_O, PyDoc_STR("Retrieve a timedelta representing the amount of DST applied " "in a zone at the given datetime.")}, {"tzname", (PyCFunction)zoneinfo_tzname, METH_O, PyDoc_STR("Retrieve a string containing the abbreviation for the time " "zone that applies in a zone at a given datetime.")}, {"fromutc", (PyCFunction)zoneinfo_fromutc, METH_O, PyDoc_STR("Given a datetime with local time in UTC, retrieve an adjusted " "datetime in local time.")},Because they don't have any argument parsing logic in them.
Just improving the signature? If this is desired, I can send an extra PR later :)
New
helpoutput:zoneinfoto argument clinic #97955