Skip to content

GH-90352: fix _SelectorDatagramTransport to inherit from DatagramTransport #98844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gvanrossum merged 2 commits into from
Oct 29, 2022
Merged

GH-90352: fix _SelectorDatagramTransport to inherit from DatagramTransport #98844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a21ad2
fix inheritance
kumaraditya303 Oct 29, 2022
69966e2
📜🤖 Added by blurb_it.
blurb-it[bot] Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/asyncio/selector_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,7 +1126,7 @@ def _reset_empty_waiter(self):
self._empty_waiter = None


class _SelectorDatagramTransport(_SelectorTransport):
class _SelectorDatagramTransport(_SelectorTransport, transports.DatagramTransport):

_buffer_factory = collections.deque

Expand Down
4 changes: 4 additions & 0 deletions Lib/test/test_asyncio/test_selector_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,6 +1081,10 @@ def test_read_ready(self):
self.protocol.datagram_received.assert_called_with(
b'data', ('0.0.0.0', 1234))

def test_transport_inheritance(self):
transport = self.datagram_transport()
self.assertIsInstance(transport, asyncio.DatagramTransport)

def test_read_ready_tryagain(self):
transport = self.datagram_transport()

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-10-29-09-42-20.gh-issue-90352.t8QEPt.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix ``_SelectorDatagramTransport`` to inherit from :class:`~asyncio.DatagramTransport` in :mod:`asyncio`. Patch by Kumar Aditya.