Skip to content

gh-98433: Fix quadratic time idna decoding. #99092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 8 commits into from
Nov 8, 2022
Merged

gh-98433: Fix quadratic time idna decoding. #99092

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
365a6cb
gh-98433: Fix quadratic time idna decoding.
gpshead Nov 4, 2022
4bf248b
drop the timing test, add an upfront limit.
gpshead Nov 4, 2022
db498cb
Expand the label limit comments.
gpshead Nov 4, 2022
be30a48
Also add a short "too long" test assert.
gpshead Nov 4, 2022
038bbcd
Refactor into nicer code. Expand the NEWS entry.
gpshead Nov 4, 2022
cf3a20e
news wording tweak.
gpshead Nov 4, 2022
bd51456
more RFC links and explanation.
gpshead Nov 4, 2022
5a3b037
assertRaisesRegex
gpshead Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
assertRaisesRegex 
thanks victor!
  • Loading branch information
@gpshead
gpshead committed Nov 7, 2022
commit 5a3b03750f57429f7529c9e0e3603c07d38cedd9
6 changes: 2 additions & 4 deletions Lib/test/test_codecs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,12 +1553,10 @@ def test_builtin_encode(self):
self.assertEqual("pyth\xf6n.org.".encode("idna"), b"xn--pythn-mua.org.")

def test_builtin_decode_length_limit(self):
with self.assertRaises(UnicodeError) as ctx:
with self.assertRaisesRegex(UnicodeError, "way too long"):
(b"xn--016c"+b"a"*1100).decode("idna")
self.assertIn("way too long", str(ctx.exception))
with self.assertRaises(UnicodeError) as ctx:
with self.assertRaisesRegex(UnicodeError, "too long"):
(b"xn--016c"+b"a"*70).decode("idna")
self.assertIn("too long", str(ctx.exception))

def test_stream(self):
r = codecs.getreader("idna")(io.BytesIO(b"abc"))
Expand Down