Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (30a8fd4) to head (1204b9e).
⚠️ Report is 2 commits behind head on master.

@@           Coverage Diff           @@
##           master    #1638   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         157      157           
  Lines        9750     9753    +3     
  Branches      992      993    +1     
=======================================
+ Hits         9066     9069    +3     
  Misses        484      484           
  Partials      200      200           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rytilahti This one should be good as well, here's a summary of the PR:

• Modified the default credentials to add a new TAPOCAMERA_LV3. Looking through the APK code found this new default password that was being used for the smartcamdevice.py for logging in if the username and password provided didn't work. This new password is selected from the login_version in the APK so that's what I did here.
  -Updated and modified all the tests to work with the new credentials and proper fixture handling for tests as well.

A minor thing: in the CLI, autodiscovery works, but explicitly passing --type camera does not, nor does --type camera --login-version 3. I believe this is because the code assumes, and forces/overrides login_version to 2:

    elif type in {"smart", "camera"} or (device_family and encrypt_type):
        if type == "camera":
            encrypt_type = "AES"
            https = True
            login_version = 2
            device_family = "SMART.IPCAMERA"

That said, perfect is the enemy of good :) I think this PR is necessary for some devices and working already, so I believe it should be merged as-is.

@paravoid I'll look into the CLI issues before we merge this. There's still a lot going on with other transport and protocol issues as well that are trying to be resolved before a new version is released.

@rytilahti I've rebased. I'm not really sure what #1602 is doing to be honest. Maybe. Let me pull those fixture files and see if they work with this branch. The original PR for those #1596 was closed out automatically.

@rytilahti No, #1602 still does things differently because the actual fixture files in #1596 don't work in my code here. The discovery_result is different for D225 does not have any encrypt_info and that is what the changes in #1602 fix. Then you should be able to re-open #1596 and add the fixture files from there.

This one is good to go though.

@rytilahti This should be clear to go now.

@paravoid I missed getting the fix for the CLI into this release, will get it pushed in another PR. Thanks!