Add RV30(UN) 1.0 1.2.2 device fixture#1665
Add RV30(UN) 1.0 1.2.2 device fixture#1665davidefiocco wants to merge 2 commits intopython-kasa:masterfrom
Conversation
d38718b to
34b69a2
Compare
|
The PR fails in CI, and something a bit complicated is going on I am afraid.
Also, adding "RV30" to VACUUMS_SMART also triggers This would happen for other vacuum models though: mine is the first vacuum fixture whose model name actually matches the patterns in VACUUMS_SMART (existing fixtures for the RV20 Max Plus and RV30 Max don't match "RV20"/"RV30" due to how the model name is parsed in per the logic in python-kasa/tests/fixtureinfo.py Line 140 in c9c8061 The same errors here would be seen for the other robovacuum fixtures, if they matched the set in VACUUMS_SMART. |
|
@davidefiocco It seems that the RV30 builds components differently and connects differently than the RV30 MAX or RV20 MAX PLUS, things that we use modules to read are there, just in a different place or component. So, we will need to look at how to handle the shifts in module linking for the different devices since this model is new and the encryption is different as well. Has this device been set up with the Tapo App, configured with the Cloud and had a firmware update done on it at all? |
|
Hello @ZeliardM, thanks!
Yes, to all three. Before tinkering with python-kasa I setup and use the device via the Tapo app, connect it to the internet so that I can start cleaning job when I am not home and also yes, I updated the firmware, even though I haven't kept track of what it originally came with before 1.2.2. Does it answer your questions? |
|
@davidefiocco Yep, ok, so the fixture looks very different from the other vacuums. I'll need to look closer into it and see what we can get going. I'll more than likely setup another PR for all those changes, then I'll need to to pull everything and test it out, if you're ok with that? |
|
Sure, happy to help! I will keep an eye on your updates here about this to see if the new PR gets referenced, keep me posted! |
I propose to add a fixture for a robot vacuum: RV30(UN) 1.0, firmware 1.2.2, generated with dump_devinfo.