Skip to content

fix hkey cleanup #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rico-chet wants to merge 2 commits into from
Closed

fix hkey cleanup #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af77fc4
fix hkey cleanup
rico-chet Mar 17, 2016
6658514
Merge pull request #1 from rico-chet/rico-chet-setup-hkey-close-patch
rico-chet Mar 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ def _find_msbuild_tool(tool="msbuild.exe", use_windows_sdk=False):
paths_to_check = []
hreg = _winreg.ConnectRegistry(None, _winreg.HKEY_LOCAL_MACHINE)
try:
hkey = None
for key_to_check in keys_to_check:
sdk_name, key, value_name = key_to_check[:3]
suffix = key_to_check[3] if len(key_to_check) > 3 else None
hkey = None
try:
hkey = _winreg.OpenKey(hreg, key)
val, type_ = _winreg.QueryValueEx(hkey, value_name)
Expand All @@ -74,7 +74,8 @@ def _find_msbuild_tool(tool="msbuild.exe", use_windows_sdk=False):
except WindowsError:
pass
finally:
hkey.Close()
if hkey:
hkey.Close()
finally:
hreg.Close()

Expand Down