Merged
Conversation
Contributor
Author
|
@dmitriyse I've cherry picked your commit 0b988d2, but I can't get it to work (though it's almost there 👍). Do you see anything that may be missing? |
ae4d704 to
d2ba88a
Compare
Codecov Report@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 62.74% 62.74%
=======================================
Files 61 61
Lines 5251 5251
Branches 876 876
=======================================
Hits 3295 3295
Misses 1738 1738
Partials 218 218
Continue to review full report at Codecov.
|
Contributor
Author
|
Fixed it! We were passing the wrong size into the API call. It's ready for review/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Remove dependency on
Mono.UnixAny other comments?
Work in progress
Currently failing but almost there. Something is screwy with encoding still.
AssertionError: u'SystemQ\x00\Ue83a0778\u7f7e\Ue83a0778\u7f7e\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00' != 'System'