Skip to content

Bumpversion#398

Merged
vmuriart merged 3 commits intopythonnet:masterfrom
vmuriart:bumpversion
Feb 22, 2017
Merged

Bumpversion#398
vmuriart merged 3 commits intopythonnet:masterfrom
vmuriart:bumpversion

Conversation

@vmuriart
Copy link
Contributor

@vmuriart vmuriart commented Feb 22, 2017 •
edited
Loading

What does this implement/fix? Explain your changes.

Automate version update.
Fixes conda-recipe version from lagging (used to look at last git-tag)
Fixes and centralizes AssemblyInfo version information

Does this close any currently open issues?

Closes #319

Any other comments?

Based from: peritus/bumpversion#77 (comment)

Example usage:

bumpversion patch: 0.1.0 -> 0.1.1.dev0
bumpversion release: 0.1.1.dev0 -> 0.1.1
bumpversion minor: 0.1.1 -> 0.2.0.dev0
bumpversion dev: 0.2.0.dev0 -> 0.2.0.dev1
bumpversion release: 0.2.0.dev1 -> 0.2.0

I chose to not add auto-commit/auto-tag. For one, its broken on PY3 and also would prefer testing out before potentially causing the git-history to get extremely messy.

Checklist

Check all those that are applicable and complete.

  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS

@vmuriart
Update conda-recipe version
0e5e58e 
Get it from recipe file instead of git-tag.
@vmuriart
Add SharedAssemblyInfo & Update Assembly version
928717d 
Reset version back down to v2.x from v4.0.0.2

See link below for Semanctic Versioning & .NET
https://codingforsmarties.wordpress.com/2016/01/21/how-to-version-assemblies-destined-for-nuget/
@vmuriart
Add .bumpversion
5a7d297 
Configuration based from gh:bumpversion:issues:77#issuecomment-130696156

Usage:
bumpversion major -> increases major and adds `dev` if not present
bumpversion minor -> increases minor and adds `dev` if not present
bumpversion release -> drop the `dev` portion
@vmuriart
Copy link
Contributor Author

vmuriart commented Feb 22, 2017

conda-builds with correct version.

image

@vmuriart vmuriart self-assigned this Feb 22, 2017
@den-run-ai
Copy link
Contributor

den-run-ai commented Feb 22, 2017

@vmuriart so why not versioneer which is also internally used by conda-build? bumpversion has stalled for 2 years and it is also used 10 times less on github:

https://github.com/search?l=Python&q=bumpversion&ref=searchresults&type=Code&utf8=%E2%9C%93
https://github.com/search?l=Python&q=versioneer&type=Code&utf8=%E2%9C%93

Is it easier to use or has some features?

@vmuriart
Copy link
Contributor Author

vmuriart commented Feb 22, 2017

I forgot to add my reasoning, thanks for the reminder.

versioneer requires that the source code be checked-in with the repository and updated periodically for new updates.

the version is calculated at runtime with import versioneer; __version__ = versioneer.get_version() which works great on python script/files but not as well on static files or non-python language files (such as our use case). bumpversion on the other hand statically updates all the files. In the end this is what tipped the scales.

bumpversion has alot of quirks (which I documented for how annoying they were) but in the end was the simpler solution. I gave versioneer multiple tries but in the end I couldn't integrate it for our use.

@den-run-ai
Copy link
Contributor

den-run-ai commented Feb 22, 2017

can you add instructions to developer docs?

https://github.com/pythonnet/pythonnet/wiki/Development-setup

@vmuriart
Copy link
Contributor Author

vmuriart commented Feb 22, 2017

Added the documentation to the wiki.
Just reviewed the search results from above, I think they are a bit skewed since versioneer commits itself into each project that uses it and might show up in the results more because of it.

@vmuriart vmuriart merged commit 909b7c0 into pythonnet:master Feb 22, 2017
@vmuriart vmuriart deleted the bumpversion branch February 22, 2017 06:43
@vmuriart vmuriart added this to the 2.3.0 milestone Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filmor filmor Awaiting requested review from filmor

@tonyroberts tonyroberts Awaiting requested review from tonyroberts

1 more reviewer

@den-run-ai den-run-ai den-run-ai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vmuriart vmuriart

Labels

None yet

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

Automate version update

2 participants

@vmuriart @den-run-ai