Codecov Report

Merging #628 into master will decrease coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #628      +/-   ##
=========================================
- Coverage   76.99%   76.9%   -0.09%     
=========================================
  Files          64      64              
  Lines        5612    5582      -30     
  Branches      888     888              
=========================================
- Hits         4321    4293      -28     
+ Misses       1002    1000       -2     
  Partials      289     289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18285f...adc1240. Read the comment docs.

@Cronan related PR from @ArvidJB, where he introduced AssemblyList:

#277

@Cronan I'm all for not using our own implementation of concurrent collection and use .NET types :)

Here is one case to consider:

             var names = new List<AssemblyName>(assemblies.Count);

Is it possible that new elements are added to assemblies concurrently before the next line with iteration starts and hence .Count is not correct for the size of names anymore?
This may sound crazy scenario, but I would hate to debug concurrency bugs.
So maybe add a lock around this?

@denfromufa that line is just a hint to pre-allocate assemblies.Count slots in the List and if you get that wrong the only implication is that it needs to reallocate the internal array in the List.

I think the only real difference here is that ConcurrentBag does not try to maintain any ordering of the elements you add. The ordering of the assemblies would dictate the resolution for classes which are present in multiple assemblies (not sure how frequent this actually is). Switching the order during the evaluation of the program could lead to inconsistent class definitions.
I would think that's why I wrote that custom class, but I don't really remember, to be honest.

@ArvidJB so what do you recommend?

@ArvidJB @denfromufa ConcurrentQueue would preserve the ordering, and also allow threadsafe snapshot enumeration.

this PR complies with point 1 from these new rules:

#610