Implementing GetDynamicMemberNames() for PyObject#690
Implementing GetDynamicMemberNames() for PyObject#690den-run-ai merged 5 commits intopythonnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #690 +/- ##
=========================================
+ Coverage 76.81% 76.9% +0.09%
=========================================
Files 63 63
Lines 5580 5582 +2
Branches 890 890
=========================================
+ Hits 4286 4293 +7
+ Misses 1003 998 -5
Partials 291 291
Continue to review full report at Codecov.
|
filmor
left a comment
There was a problem hiding this comment.
Fine for the most part, just check the two comments and add yourself to the contributors list (if you are not in there yet) and we can merge this. Thank you very much for this addition, good idea :)
| <PropertyGroup Condition=" '$(Configuration)' == 'DebugMono'"> | ||
| <DebugSymbols>true</DebugSymbols> | ||
| <DefineConstants Condition="'$(DefineConstants)' == ''">DEBUG;TRACE</DefineConstants> | ||
| <DefineConstants Condition="'$(DefineConstants)' == ''">PYTHON2;PYTHON27;UCS4;TRACE;DEBUG</DefineConstants> |
There was a problem hiding this comment.
These changes are not necessary, are they?
src/embed_tests/TestPyObject.cs
Outdated
| #if PYTHON3 | ||
| "__ne__", | ||
| #endif | ||
| "__new__", |
There was a problem hiding this comment.
The defines here make the whole thing quite brittle, I think, to me it would be perfectly fine to just check that the explicitly added members exist (i.e. add, getNumber etc.).
This reverts commit 56e5268.
|
Thanks for the feedback. I've addressed your comments. |
|
@denfromufa When you are through, please remember to squash this one before merging, as it contains quite a bit of unnecessary back and forth due to the accidental project file changes. |
What does this implement/fix? Explain your changes.
This change implements GetDynamicMemberNames() for PyObject. This allows dynamic object members to be visible in the Visual Studio debugger.
Does this close any currently open issues?
#443
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG