Catching exceptions from iterator MoveNext(), additional testing (issue #475, original pull request #523)#693
Merged
filmor merged 6 commits intopythonnet:masterfrom Jun 26, 2018
Merged
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 76.9% 76.93% +0.02%
==========================================
Files 63 63
Lines 5582 5589 +7
Branches 890 891 +1
==========================================
+ Hits 4293 4300 +7
Misses 998 998
Partials 291 291
Continue to review full report at Codecov.
|
Member
|
@rickardraysearch @ArvidJB Thank you very much for your contribution and sorry (especially to @rickardraysearch) for the long time until it was finally merged. Just to clarify, the question I had was a pure lack-of-understanding question, I'm fine if this behaviour (i.e. always traverse exactly one level into the exception chain) if it's consistent with the rest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This request contains the changes from #523 and adds some additional testing as requested in the comments on that request
Does this close any currently open issues?
Issue #475
Any other comments?
...
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG