Don't use repr in __str__. Clean up unneeded tests

pythonnet · filmor · Oct 18, 2019 · Jan 20, 2019 · Mar 6, 2019 · Mar 8, 2019
commit accc7978c657f0e524eb32f1d2a4cdc2a6e08db1
diff --git a/src/runtime/classbase.cs b/src/runtime/classbase.cs
@@ -233,34 +233,7 @@ public static IntPtr tp_str(IntPtr ob)
             }
             try
             {
-                //As per python doc:
-                //The return value must be a string object.  If a class defines __repr__() but not __str__(),
-                //then __repr__() is also used when an “informal” string representation of instances of that
-                //class is required.
-                //In C#, everything provides ToString(), so the check here will be whether the type explicitly
-                //provides ToString() or if it is language provided (i.e. the fully qualified type name as a string)
-
-                //First check which type in the object hierarchy provides ToString()
-                //ToString has two "official" overloads so loop over GetMethods to get the one without parameters
-                var instType = co.inst.GetType();
-                var method = instType.GetMethod("ToString", new Type[]{});
-                if (method.DeclaringType != typeof(object))
-                {
-                    //match!  something other than object provides a parameter-less overload of ToString
-                    return Runtime.PyString_FromString(co.inst.ToString());
-                }
-
-                //If the object defines __repr__, call it.
-                System.Reflection.MethodInfo reprMethodInfo = instType.GetMethod("__repr__");
-                if (reprMethodInfo != null && reprMethodInfo.IsPublic)
-                {
-                    var reprString = (string)reprMethodInfo.Invoke(co.inst, null);
-                    return Runtime.PyString_FromString(reprString);
-                }
-
-                //otherwise fallback to object's ToString() implementation
                 return Runtime.PyString_FromString(co.inst.ToString());
-
             }
             catch (Exception e)
             {

diff --git a/src/tests/test_repr.py b/src/tests/test_repr.py
@@ -19,12 +19,6 @@ def test_system_string():
     assert str(ob) == "hello"
     assert "<System.String object at " in ob.__repr__()
 
-def test_repr_only():
-    """Test class implementing __repr__() but not ToString()"""
-    ob = ReprTest.Foo()
-    assert str(ob) == "I implement __repr__() but not ToString()!"
-    assert ob.__repr__() == "I implement __repr__() but not ToString()!"
-
 def test_str_only():
     """Test class implementing ToString() but not __repr__()"""
     ob = ReprTest.Bar()