The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Mar 24, 2026 5:15pm

PR Summary

Medium Risk
Adds a new persisted UI metadata field (columnOrder) and updates table interactions (drag, rename, insert, delete) to mutate it, which could affect how columns render and how selection/index-based logic behaves. Risk is mostly UI/state consistency; no auth or data-model writes beyond metadata merging.

Overview
Adds drag-and-drop column reordering in the table UI and persists the chosen order via a new TableMetadata.columnOrder field.

Updates table rendering and selection logic to use displayColumns (schema columns ordered by columnOrder with a fallback for missing/new columns), and syncs metadata updates on drag end as well as on column rename/insert/delete. The table metadata API now validates and accepts columnOrder alongside columnWidths.

^{Written by Cursor Bugbot for commit 12ced58. Configure here.}

Greptile Summary

This PR adds native HTML5 drag-and-drop column reordering to the table component. A displayColumns memo computes the visual order from a persisted columnOrder array, and the drag lifecycle (dragstart → dragover → drop/dragend) updates that array both locally and via the existing metadata API. The feature integrates cleanly with the existing column rename, insert-left/right, and delete flows, keeping columnOrder in sync with each operation.

Key changes:

• displayColumns memo correctly falls back to schema order when no order is set, and appends unknown columns at the tail
• Resize-handle conflict is prevented with draggable={false} + e.stopPropagation() on the resize thumb
• deleteColumnMutation now updates columnOrder in onSuccess (fixing a prior optimistic-update bug)
• insertColumnInOrder correctly no-ops when columnOrderRef.current is null (first-drag captures order)
• One outstanding issue: in the columnRename handler, updateMetadataRef.current is only called when columnOrderRef.current is non-null, so a column that has a custom width but was renamed before any drag has occurred will lose its width on the next page load

Confidence Score: 4/5

• Safe to merge after the rename-path width persistence fix; all prior review concerns have been resolved.
• The drag-and-drop logic is well-structured, prior issues (double invocation, optimistic delete rollback) have been addressed, and the type/API changes are minimal. One concrete P1 remains: renaming a column with a custom width before any drag has occurred skips updateMetadataRef.current, causing the width to be lost on the next page load. That fix is a one-liner in the rename handler.
• apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx — specifically the columnRename.onSave handler around line 369

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant User
    participant TH as ColumnHeaderMenu (th)
    participant Table as Table (parent)
    participant API as /api/table/[id]/metadata

    User->>TH: dragstart
    TH->>Table: onDragStart(columnName)
    Table->>Table: setDragColumnName(columnName)

    User->>TH: dragover (hover target column)
    TH->>TH: compute side (left/right) from clientX
    TH->>Table: onDragOver(targetName, side)
    Table->>Table: setDropTargetColumnName / setDropSide
    TH-->>User: show drop indicator (2px line)

    User->>TH: drop (release)
    TH->>TH: handleDrop (e.preventDefault only)

    User->>TH: dragend (fires on source)
    TH->>Table: onDragEnd()
    Table->>Table: compute newOrder from columnOrderRef / displayColumns
    Table->>Table: setColumnOrder(newOrder)
    Table->>API: PUT metadata {columnWidths, columnOrder}
    API-->>Table: { success: true }
    Table->>Table: setDragColumnName(null) / setDropTargetColumnName(null)

_{Reviews (4): Last reviewed commit: "fix(table): prevent stale refs during co..." | Re-trigger Greptile}

@cursor review

@greptile

@greptile

@cursor review

@greptile

@cursor review