Handle array attributes in hash/equality methods.#28
Merged
Conversation
davetron5000
approved these changes
May 1, 2017
| return false unless other.is_a?(klass) | ||
| attributes.all? { |attribute| self.send(attribute) == other.send(attribute) } | ||
| attributes.all? do |attribute| | ||
| if attribute.kind_of?(Array) and attribute.size == 1 |
Contributor
There was a problem hiding this comment.
Is this because attribute is using that syntax [:widgets]?
Contributor
Author
There was a problem hiding this comment.
That's right... for array attributes, we're trying to send that to the instance send([:widgets])...
Contributor
|
Curious about the failure in travis for |
Contributor
|
rbx is rubinius. It says there are no binaries to download, so maybe that's not the right name for Rubinius? Latest is version 3, so let's try |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Array attributes are not handled in
#==,#eql?, and#hash. ATypeErroris raised when callingsendwith the attribute within#==andhash.Solution
Unwrap array attribute names (similar to
.initialize) in the#==and#hashmethods.