Deprecate js override bits#119
Merged
Merged
Conversation
0d7f59b to
7735f9a
Compare
They were a feature for testing whose need was removed in 2015 (ua-parser/uap-core#58). They are *entirely* unnecessary, it is possible a user somewhere is leveraging them for some reason. So remove the override bits from the docstrings, and have them trigger a `DeprecationWarning`. Also: - add tests that they do trigger - remove support for them from the yaml testing functions - update the pytest invocations to raise on all warnings - while at it remove the apparently dead makePGTSComparisonYAML test utility method (?) - and add pypy to the envlist Note: `simplefilter` has to be updated to `"always"` for 2.7's dumb ass: the new tests triggers the same warning multiple times and of course `"default"` only yields them once. final
5bf7599 to
71eb922
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They were a feature for testing whose need was removed in 2015 (ua-parser/uap-core#58). They are entirely unnecessary, it is possible a user somewhere is leveraging them for some reason.
So remove the override bits from the docstrings, and have them trigger a
DeprecationWarning.Also: