Skip to content

cat: avoid splice for small files#11523

Draft
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:cat-small-file
Draft

cat: avoid splice for small files#11523
oech3 wants to merge 1 commit intouutils:mainfrom
oech3:cat-small-file

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented Mar 27, 2026 •
edited
Loading

Closes #10835
@FidelSch Would you bench? My hyperfile is not stable.

xtqqczze
xtqqczze reviewed Mar 27, 2026
View reviewed changes
src/uu/cat/src/cat.rs
{
// If we're on Linux or Android, try to use the splice() system call
// for faster writing. If it works, we're done.
// splice is slow for small files (issue/10832)
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// splice is slow for small files (issue/10832)
// splice is slow for small files (https://github.com/uutils/coreutils/issues/10832)

please use full URL for issues so link can be followed from IDE

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

GNU testsuite comparison:

Skipping an intermittent issue tests/date/date-locale-hour (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/pr/bounded-memory (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.
Congrats! The gnu test tests/dd/no-allocate is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@xtqqczze xtqqczze xtqqczze left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @xtqqczze