separate pythonClassName from pythonFunction#30
Closed
koka831 wants to merge 8 commits intovim-python:masterfrom
Closed
separate pythonClassName from pythonFunction#30koka831 wants to merge 8 commits intovim-python:masterfrom
koka831 wants to merge 8 commits intovim-python:masterfrom
Conversation
Member
|
Thanks, waiting for the improved regex. |
following pythonFunction way.
Contributor
Author
|
now I created |
|
Layman here so I don't think I'm qualified to leave an actual review, but I tried this and it works well for me. I changed the color to Special because that works better in my theme, but everything seems to work as expected. |
|
Works great, @nfnty any specific reason to not merge this? |
Contributor
Author
|
@nfnty may I ask you, what do you mean by
If this PR don't work as expected, I'll fix it. |
|
Any updates on this PR? Works fine for me. |
Member
|
Thanks! |
cdonovick
pushed a commit
to cdonovick/python-syntax
that referenced
this pull request
Apr 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #18
This is the enhancement to separate classname from function name.
about regexp of
pythonClassName, I intend to make it compliant with pep.