fix(html): handle trailing slash in htmlPath for relative URL pre-transform#21429
Open
VedantMadane wants to merge 1 commit intovitejs:mainfrom
Open
fix(html): handle trailing slash in htmlPath for relative URL pre-transform#21429VedantMadane wants to merge 1 commit intovitejs:mainfrom
VedantMadane wants to merge 1 commit intovitejs:mainfrom
Conversation
…nsform When htmlPath ends with a slash (e.g., '/example/dir/'), path.posix.dirname() returns '/example' instead of '/example/dir', causing relative script URLs to be resolved in the wrong directory. This can occur when implementing an SSR dev server following the guide, where the url passed to transformIndexHtml() may end with a slash. Fixes vitejs#18964
2f1f611 to
0267462
Compare
Author
|
Hi @vitejs, I've updated this PR. Could you please take a look when you have a moment? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When implementing an SSR dev server following the SSR guide, the URL passed to
transformIndexHtml()may end with a slash (e.g.,/example/dir/instead of/example/dir/index.html).In this case,
path.posix.dirname()returns the parent directory instead of the expected current directory:path.posix.dirname('/example/dir/')returns/example(wrong)/example/dirThis causes relative script URLs in the HTML to be pre-transformed with the wrong base path, resulting in:
Fix
When
htmlPathends with/, we treat it as a directory path and remove the trailing slash to get the correct directory, instead of callingdirname().Related Issue
Fixes #18964
What is the purpose of this pull request?
Checklist